Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Item): clamp composite bar item #342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(Item): clamp composite bar item #342

wants to merge 1 commit into from
+8 −8

Conversation

vladimir-kuba
Copy link
Contributor

Fixes #340

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@vladimir-kuba vladimir-kuba force-pushed the feat/clamp-composite-bar-item branch 2 times, most recently from 4406034 to 89a39e4 Compare December 25, 2024 20:31
@DarkGenius
Copy link
Collaborator

DarkGenius commented Dec 27, 2024 •
edited
Loading

How will the element title be displayed if 2 lines are not enough? And please add to storybook item with long text and tag New

@vladimir-kuba vladimir-kuba force-pushed the feat/clamp-composite-bar-item branch from c8a0ef5 to 4552961 Compare December 28, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkGenius DarkGenius Awaiting requested review from DarkGenius DarkGenius is a code owner

@Lunory Lunory Awaiting requested review from Lunory Lunory is a code owner

@sunduckcow sunduckcow Awaiting requested review from sunduckcow sunduckcow is a code owner

@kendoow kendoow Awaiting requested review from kendoow kendoow is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Composite bar items title long text clamp
3 participants
@vladimir-kuba @gravity-ui-bot @DarkGenius