Skip to content

Commit

Permalink
fix(Toast): fix overflows (#1079)
Browse files Browse the repository at this point in the history
  • Loading branch information
lunaticenslaved authored Nov 9, 2023
1 parent 6af17ea commit 2205fde
Show file tree
Hide file tree
Showing 4 changed files with 43 additions and 8 deletions.
2 changes: 2 additions & 0 deletions src/components/Toaster/Toast/Toast.scss
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ $block: '.#{variables.$ns}toast';
width: 100%;
height: 100%;
min-height: var(--g-text-body-2-line-height);
min-width: 0;
grid-template-columns: 100%;

&:before {
content: '';
Expand Down
1 change: 1 addition & 0 deletions src/components/Toaster/Toast/Toast.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ function renderActions({actions, onClose}: RenderActionsProps) {
type="button"
size={'l'}
view={view}
width="auto"
>
{label}
</Button>
Expand Down
14 changes: 8 additions & 6 deletions src/components/Toaster/__stories__/Toaster.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react';

import type {ComponentMeta, ComponentStory} from '@storybook/react';
import type {Meta, StoryObj} from '@storybook/react';

import type {ButtonView} from '../../Button';
import {ToasterProvider} from '../Provider/ToasterProvider';
Expand Down Expand Up @@ -85,9 +85,11 @@ export default {
);
},
],
} as ComponentMeta<typeof Toast>;
} as Meta<typeof Toast>;

const DefaultTemplate: ComponentStory<typeof Toast & typeof ToasterDemo> = (args) => (
<ToasterDemo {...args} />
);
export const Default = DefaultTemplate.bind({});
type Story = StoryObj<typeof Toast & typeof ToasterDemo>;

export const Default: Story = {
args: {},
render: (props) => <ToasterDemo {...props} />,
};
34 changes: 32 additions & 2 deletions src/components/Toaster/__stories__/ToasterShowcase.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {faker} from '@faker-js/faker/locale/en';
import {CircleCheck, CircleInfo, Thunderbolt, TriangleExclamation} from '@gravity-ui/icons';

import {ToasterComponent, useToaster} from '..';
import type {ToastProps} from '..';
import type {ToastAction, ToastProps} from '..';
import {Button} from '../../Button';
import type {ButtonView} from '../../Button';
import {Icon} from '../../Icon';
Expand Down Expand Up @@ -75,6 +75,7 @@ export const ToasterDemo = ({
type?: ToastProps['type'];
className?: string;
content?: React.ReactNode;
actions?: ToastAction[];
}): ToastProps {
let content: React.ReactNode = null;
let title;
Expand Down Expand Up @@ -108,7 +109,7 @@ export const ToasterDemo = ({
...action,
view: index === 0 ? action1View : action2View,
}))
: undefined,
: extra.actions,
};
}

Expand Down Expand Up @@ -232,6 +233,28 @@ export const ToasterDemo = ({
setState((state) => ({...state, lastToastName: toastProps.name}));
};

const createToastLongContent = () => {
const toastProps = getToastProps({
name: 'overflow',
type: 'error',
title: 'Lorem ipsum dolor sit amet consectetur adipisicing elit.',
content:
'Excepturi cumque dicta, et a repellat culpa totam minus vero, error ducimus nesciunt? Dicta soluta earum sapiente explicabo commodi pariatur nulla eius?',
actions: [
{
label: 'Lorem ipsum dolor sit amet consectetur adipisicing elit.',
onClick: () => {
console.log('Lorem ipsum dolor sit amet consectetur adipisicing elit.');
},
},
],
});

toaster.add(toastProps);

setState((state) => ({...state, lastToastName: toastProps.name}));
};

const createDynamicallyUpdatingToast = () => {
const toastProps = getToastProps({
name: 'UpdatingToast',
Expand Down Expand Up @@ -324,6 +347,12 @@ export const ToasterDemo = ({
</Button>
);

const toastWithLongContent = (
<Button view="outlined" size="l" onClick={createToastLongContent} style={btnStyle}>
Create toast with long content
</Button>
);

const dynamicallyUpdatingToast = (
<Button size="l" onClick={createDynamicallyUpdatingToast} style={btnStyle}>
Create dynamically updating toast
Expand Down Expand Up @@ -353,6 +382,7 @@ export const ToasterDemo = ({
<p>{errorToastBtn}</p>
<p>{utilityToastBtn}</p>
<p>{customToastBtn}</p>
<p>{toastWithLongContent}</p>
<p>{dynamicallyUpdatingToast}</p>
<p>{overrideToastBtn}</p>
<p>{clearBtn}</p>
Expand Down

0 comments on commit 2205fde

Please sign in to comment.