fix(PlaceholderContainer): remove href attribute fallback in actions (#…

…1947) Co-authored-by: Aleksandr Burobin <lxndr-b@yandex-team.ru>
gravity-ui · Nov 14, 2024 · 60a8b92 · 60a8b92
1 parent 6a09bbc
commit 60a8b92
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/components/PlaceholderContainer/PlaceholderContainer.tsx b/src/components/PlaceholderContainer/PlaceholderContainer.tsx
@@ -19,7 +19,7 @@ const PlaceholderContainerAction = (props: PlaceholderContainerActionProps) => {
                 size={props.size || 'm'}
                 loading={Boolean(props.loading)}
                 disabled={Boolean(props.disabled)}
-                href={props.href || ''}
+                href={props.href}
                 {...(props.onClick ? {onClick: props.onClick} : {})}
             >
                 {props.text}

diff --git a/src/components/PlaceholderContainer/__stories__/PlaceholderContainer.stories.tsx b/src/components/PlaceholderContainer/__stories__/PlaceholderContainer.stories.tsx
@@ -88,6 +88,12 @@ const actionAdditionalBtnProps: PlaceholderContainerActionProps = {
     onClick: () => alert('Click by additional button'),
 };
 
+const actionLinkProps: PlaceholderContainerActionProps = {
+    text: 'Link button',
+    view: 'flat-info',
+    href: 'https://gravity-ui.com/',
+};
+
 export const Default: Story = {
     args: {
         title: 'Some title',
@@ -165,7 +171,7 @@ export const Actions: Story = {
                 <PlaceholderContainer
                     {...args}
                     title="Array of actions"
-                    actions={[actionMainProps, actionAdditionalBtnProps]}
+                    actions={[actionMainProps, actionAdditionalBtnProps, actionLinkProps]}
                 />
             </Showcase>
             <Showcase>