feat!: rename theme prop positive -> success (#1093)

gravity-ui · Feb 1, 2024 · d3f76d5 · d3f76d5
1 parent 8edc1d3
commit d3f76d5
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 33 deletions.
diff --git a/src/components/Alert/Alert.test.tsx b/src/components/Alert/Alert.test.tsx
@@ -72,7 +72,7 @@ describe('Alert', () => {
         expect(container).toMatchSnapshot();
     });
 
-    test.each<AlertTheme>(['danger', 'info', 'positive', 'success', 'warning', 'utility'])(
+    test.each<AlertTheme>(['danger', 'info', 'success', 'warning', 'utility'])(
         'render correct icon if not normal theme',
         async (theme) => {
             const {container} = render(

diff --git a/src/components/Alert/AlertIcon.tsx b/src/components/Alert/AlertIcon.tsx
@@ -31,10 +31,6 @@ const typeToIcon: Record<
         filled: CircleInfoFill,
         outlined: CircleInfo,
     },
-    positive: {
-        filled: CircleCheckFill,
-        outlined: CircleCheck,
-    },
     success: {
         filled: CircleCheckFill,
         outlined: CircleCheck,

diff --git a/src/components/Alert/__stories__/Alert.stories.tsx b/src/components/Alert/__stories__/Alert.stories.tsx
@@ -61,7 +61,7 @@ const stories: AlertProps[] = [
     {
         title,
         message,
-        theme: 'positive',
+        theme: 'success',
         view: 'outlined',
         actions: (
             <Alert.Actions>
@@ -74,7 +74,7 @@ const stories: AlertProps[] = [
     {
         title,
         message,
-        theme: 'positive',
+        theme: 'success',
         view: 'filled',
 
         actions: [{text: right, handler: console.log}],

diff --git a/src/components/Alert/types.ts b/src/components/Alert/types.ts
@@ -3,14 +3,7 @@ import type React from 'react';
 import type {ButtonProps} from '../Button';
 import type {QAProps} from '../types';
 
-export type AlertTheme =
-    | 'normal'
-    | 'info'
-    | 'success'
-    | /** @deprecated */ 'positive'
-    | 'warning'
-    | 'danger'
-    | 'utility';
+export type AlertTheme = 'normal' | 'info' | 'success' | 'warning' | 'danger' | 'utility';
 export type AlertView = 'filled' | 'outlined';
 export type AlertLayout = 'vertical' | 'horizontal';
 export type AlertCorners = 'rounded' | 'square';

diff --git a/src/components/Card/Card.scss b/src/components/Card/Card.scss
@@ -120,7 +120,6 @@ $block: '.#{variables.$ns}card';
             }
         }
 
-        &#{$block}_theme_positive,
         &#{$block}_theme_success {
             &#{$block}_view_outlined {
                 border: 1px solid var(--g-color-line-positive);

diff --git a/src/components/Card/Card.tsx b/src/components/Card/Card.tsx
@@ -12,14 +12,7 @@ type SelectionCardView = 'outlined' | 'clear';
 type ContainerCardView = 'outlined' | 'filled' | 'raised';
 
 export type CardType = 'selection' | 'action' | 'container';
-export type CardTheme =
-    | 'normal'
-    | 'info'
-    | 'success'
-    | /** @deprecated */ 'positive'
-    | 'warning'
-    | 'danger'
-    | 'utility';
+export type CardTheme = 'normal' | 'info' | 'success' | 'warning' | 'danger' | 'utility';
 export type CardView = SelectionCardView | ContainerCardView;
 export type CardSize = 'm' | 'l';
 

diff --git a/src/components/Card/__tests__/Card.test.tsx b/src/components/Card/__tests__/Card.test.tsx
@@ -12,15 +12,7 @@ const cardText = 'Some text';
 
 const cardSizes: CardSize[] = ['l', 'm'];
 
-const cardThemes: CardTheme[] = [
-    'danger',
-    'info',
-    'normal',
-    'success',
-    'positive',
-    'warning',
-    'utility',
-];
+const cardThemes: CardTheme[] = ['danger', 'info', 'normal', 'success', 'warning', 'utility'];
 
 const cardTypes: CardType[] = ['action', 'container', 'selection'];