test(Button): improve button tests #1756
Conversation
|
Preview is ready. |
|
Visual Tests Report is ready. |
itwillwork
changed the title
| @@ -10,6 +10,7 @@ export const expectScreenshotFixture: PlaywrightFixture<ExpectScreenshotFixture> | |||
| const expectScreenshot: ExpectScreenshotFixture = async ({ | |||
| component, | |||
| screenshotName, | |||
| screenshotPostfix, | |||
There was a problem hiding this comment.
For multiple screenshots per test
test(........., () => {
await expectScreenshot();
//...
await expectScreenshot({
screenshotPostfix: 'after hover',
});
});
| options?: Options, | ||
| ) => { | ||
| const scenarioDetails: ScenarioDetails = { | ||
| tag: ['@smoke', ...(options?.additionalTags || [])], | ||
| }; | ||
|
|
||
| const scenarioName: ScenarioName = `smoke scenario${options?.scenarioName ? ` ${options?.scenarioName}` : ''}`; |
There was a problem hiding this comment.
For a more declarative name of the generated test name
before
after
There was a problem hiding this comment.
What if we shorten this to smoke [default] or smoke [view: action], omit scenario and props words
|
|
||
| await expectScreenshot({ | ||
| screenshotPostfix: 'after hover', | ||
| }); |
There was a problem hiding this comment.
Added hover test for the button
| @@ -10,6 +10,7 @@ export const expectScreenshotFixture: PlaywrightFixture<ExpectScreenshotFixture> | |||
| const expectScreenshot: ExpectScreenshotFixture = async ({ | |||
| component, | |||
| screenshotName, | |||
| screenshotPostfix, | |||
| await root.getByTestId(qa).hover(); | ||
|
|
||
| await expectScreenshot({ | ||
| screenshotPostfix: 'after hover', |
There was a problem hiding this comment.
Let's use hovered, thus screenshot name will be more readable: Button-smoke-hovered-...
| options?: Options, | ||
| ) => { | ||
| const scenarioDetails: ScenarioDetails = { | ||
| tag: ['@smoke', ...(options?.additionalTags || [])], | ||
| }; | ||
|
|
||
| const scenarioName: ScenarioName = `smoke scenario${options?.scenarioName ? ` ${options?.scenarioName}` : ''}`; |
There was a problem hiding this comment.
What if we shorten this to smoke [default] or smoke [view: action], omit scenario and props words
| @@ -10,6 +10,7 @@ export const expectScreenshotFixture: PlaywrightFixture<ExpectScreenshotFixture> | |||
| const expectScreenshot: ExpectScreenshotFixture = async ({ | |||
| component, | |||
| screenshotName, | |||
There was a problem hiding this comment.
Let's remove screenshotName (it's not used anywhere), and instead of screenshotPostfix introduce nameSuffix option
No description provided.