feat!: use native copy method #1852
Open
+90
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogonkov
requested review from
goshander,
SeqviriouM,
Raubzeug,
amje,
ValeraS and
korvin89
as code owners
|
Preview is ready. |
|
Visual Tests Report is ready. |
ogonkov
force-pushed
the
feat/native_copy
branch
from
0c4054d to
8afb15d
Compare
Raubzeug
requested changes
Sep 12, 2024
ogonkov
force-pushed
the
feat/native_copy
branch
from
cc4705e to
d6bc68b
Compare
Raubzeug
requested changes
Oct 14, 2024
ogonkov
force-pushed
the
feat/native_copy
branch
from
3ded266 to
6f1539a
Compare
ogonkov
requested review from
IsaevAlexandr,
Arucard89,
mournfulCoroner,
DakEnviy,
zamkovskaya,
kseniya57,
Marginy605,
Estasie,
axtk and
Lunory
as code owners
amje
requested changes
Dec 26, 2024
| const content = React.useMemo<React.ReactElement<React.HTMLAttributes<HTMLElement>>>( | ||
| () => children(status), | ||
| [children, status], | ||
| ); |
There was a problem hiding this comment.
It's no benefit of useMemo at all, children as function typically inline in jsx, so every render is new instance
| if (text === textRef.current) { | ||
| handleCopy(text, result); | ||
|
|
||
| content.props?.onClick?.(event); |
There was a problem hiding this comment.
Shouldn't we call this onClick unconditionally?
| /> | ||
| </ReactCopyToClipboard> | ||
| <CopyToClipboard text={copyText}> | ||
| {() => ( |
There was a problem hiding this comment.
Let's support normal children type as well as it was in ReactCopyToClipboard ? I find it usefull, if I don't need status feedback
| @@ -0,0 +1,7 @@ | |||
| export function copyText(text: string) { | |||
There was a problem hiding this comment.
This file is not needed to be at the root utils, place it near the component please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes:
optionsofcopy-to-clipboardremoved from propsFixes #658