Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update screenshot #1261

Closed
gravitystorm opened this issue Jan 27, 2015 · 12 comments
Closed

update screenshot #1261

gravitystorm opened this issue Jan 27, 2015 · 12 comments

Comments

@gravitystorm
Copy link
Owner

Our screenshot in the README is outdated - we've changed a bunch of colours recently, most noticeably the buildings. The replacement should cover the same area + zoom

@althio
Copy link

althio commented Jan 27, 2015

I don't know how to put the file in https://raw.github.com/gravitystorm/openstreetmap-carto/master/preview.png

If that helps here are the files:

before
image

after
preview

@pnorman
Copy link
Collaborator

pnorman commented Jan 27, 2015

I think you've got a different zoom on the one after - shield sizes have changed in your screenshot, but not in the stylesheet.

@matthijsmelissen
Copy link
Collaborator

I don't know how to put the file in https://raw.github.com/gravitystorm/openstreetmap-carto/master/preview.png

Best to create a pull request, this should explain how:
https://help.github.com/articles/fork-a-repo/
https://help.github.com/articles/using-pull-requests/

Let us know if anything is unclear.

@althio
Copy link

althio commented Jan 27, 2015

@pnorman

I think you've got a different zoom on the one after

I will double check but zoom levels immediately above and under looked significantly different.

@math1985

Let us know if anything is unclear.

What was unclear for me is how to access the folder and put a file in raw.github.com/gravitystorm/openstreetmap-carto/master
But master is the branch, not a folder and I guess 'raw' is not relevant.
I think I found the current file now.

@althio
Copy link

althio commented Jan 28, 2015

@pnorman

I think you've got a different zoom on the one after

I will double check but zoom levels immediately above and under looked significantly different.

I was on the correct zoom (z15) but I used Share/Image/Download and it does look slighly different than direct screenshot. I am not sure if there is a difference in "quality" or sharpness also.

z14 - direct screenshot
preview-chicago-z14

z15 - direct screenshot
preview-chicago-z15
z15 - Share/Image/Download
preview
current file in repo
image

z16 - direct screenshot
preview-chicago-z16

@pnorman
Copy link
Collaborator

pnorman commented Jan 28, 2015

share image/download generates a new image, and has nothing to do with the zoom on the website you were viewing at. A screenshot is always best for this kind of example

@althio althio mentioned this issue Jan 28, 2015
@althio
Copy link

althio commented Jan 29, 2015

Approximative area:
http://www.openstreetmap.org/#map=15/41.8729/-87.6323

  • zoom 15
  • direct screenshot, no share/download
  • crop, no resize
  • size px 852*300
  • file named preview.png
    preview
    I will create a new PR when I have access to a computer with git installed. Otherwise feel free to take the file and create own PR.

@sommerluk
Copy link
Collaborator

@math1985 This issue can be closed with merge of #1279

@matthijsmelissen
Copy link
Collaborator

Indeed. By the way, if you include the text 'resolves #1261' in your PR description, the issue gets closed automatically when the PR is merged.

@nebulon42
Copy link
Contributor

Was this screenshot taken from TileMill? Otherwise there is #1208, which changes the building colour again slightly.

@althio
Copy link

althio commented Feb 2, 2015

@nebulon42

Was this screenshot taken from TileMill?

No. It was a screenshot from plain map on public website.

@nebulon42
Copy link
Contributor

Ok, so I guess we need to update the preview once again after the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants