-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unrendered man_made overrules natural #1336
Comments
Yes, that's possible, and the way this should be solved. |
While 3 is conceptually a good solution I have no clue how to implement that regarding SQL and Carto. @math1985 Maybe you can expand a bit on how you see this could be done? |
Its seems to be already done in some queries like openstreetmap-carto/project.yaml Line 117 in a392b45
Note that values of landuse other than 'forest' are transformed into null, without that COALESCE on [landuse='trolololo'; natural='forest'] would produce 'trolololo'.
transforms [landuse='trolololo'; natural='forest'] into [landuse=null; natural='forest'] - and coalesce returns 'forest'. |
Yes, that's the way to go. |
* Make sure conditions are checked in both WHERE and COALESCE Checking the condition in the WHERE class is necessary for performance. Checking the condition in the COALESCE is necessary to prevent unrendered tags blocking rendering of tags further down in the COALESCE. See also the discussion [here](gravitystorm#1038 (comment)). This is an improvement of gravitystorm#1038. This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336. * Give amenity priority over shop. This resolves gravitystorm#963. * Give tourism priority over amenity, shop, leisure, landuse, man_made, natural, and place. This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
* Make sure conditions are checked in both WHERE and COALESCE Checking the condition in the WHERE class is necessary for performance. Checking the condition in the COALESCE is necessary to prevent unrendered tags blocking rendering of tags further down in the COALESCE. See also the discussion [here](gravitystorm#1038 (comment)). This is an improvement of gravitystorm#1038. This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336. * Give amenity priority over shop. This resolves gravitystorm#963. * Give tourism priority over amenity, shop, leisure, landuse, man_made, natural, and place. This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
* Make sure conditions are checked in both WHERE and COALESCE Checking the condition in the WHERE class is necessary for performance. Checking the condition in the COALESCE is necessary to prevent unrendered tags blocking rendering of tags further down in the COALESCE. See also the discussion [here](gravitystorm#1038 (comment)). This is an improvement of gravitystorm#1038. This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336. * Give amenity priority over shop. This resolves gravitystorm#963. * Give tourism priority over amenity, shop, leisure, landuse, man_made, natural, and place. This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
* Make sure conditions are checked in both WHERE and COALESCE Checking the condition in the WHERE class is necessary for performance. Checking the condition in the COALESCE is necessary to prevent unrendered tags blocking rendering of tags further down in the COALESCE. See also the discussion [here](gravitystorm#1038 (comment)). This is an improvement of gravitystorm#1038. This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336. * Give amenity priority over shop. This resolves gravitystorm#963. * Give tourism priority over amenity, shop, leisure, landuse, man_made, natural, and place. This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
* Make sure conditions are checked in both WHERE and COALESCE Checking the condition in the WHERE class is necessary for performance. Checking the condition in the COALESCE is necessary to prevent unrendered tags blocking rendering of tags further down in the COALESCE. See also the discussion [here](gravitystorm#1038 (comment)). This is an improvement of gravitystorm#1038. This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336. * Give amenity priority over shop. This resolves gravitystorm#963. * Give tourism priority over amenity, shop, leisure, landuse, man_made, natural, and place. This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
Opening a new issue after #1060 (comment)
Nodes with man_made=cross and natural=peak don't show up on the map.
Example: https://www.openstreetmap.org/node/26863070
More examples: http://overpass-turbo.eu/s/7OE
As @nebulon42 notes, in the SQL man_made takes precedence over natural , but since man_made=cross is not rendered nothing is rendered.
Related to #1269 (amenity vs tourism)
Possible solutions I can think of:
1 - reverse priority, render all natural over all man_made on the same node
...Likely to cause other issues?
1a - selectively render natural=peak over all man_made on the same node
2 - render something for man_made=cross
2a - render something special for man_made=cross and natural=peak combo
3 - more general: Have a list of things that get rendered for each key, and if the value is not on that list, look for another possible key to render. No idea if that is realistically possible, or if it would open other problems.
The text was updated successfully, but these errors were encountered: