Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate woodland polygon rendering by leaf_cycle #1756

Open
BushmanK opened this issue Aug 16, 2015 · 14 comments
Open

Differentiate woodland polygon rendering by leaf_cycle #1756

BushmanK opened this issue Aug 16, 2015 · 14 comments
Assignees
Labels
landcover new features Requests to render new features pattern

Comments

@BushmanK
Copy link

Once rendering style for natural=wood has changed recently, it seems like it's time to think about recently introduced, but quite popular tags such as leaf_cycle and leaf_type (more that 1 million entries in the whole world).

I made several sample patterns using current pattern used for natural=wood.

leaf_type=needleleaved no leaf_cycle
needleleaved

leaf_type=broadleaved no leaf_cycle
broadleaved

leaf_type=broadleaved leaf_cycle=deciduous
broadleaved deciduous

For leaf_cycle=evergreen, leaf_cycle=semi_evergreen, leaf_cycle=semi_deciduous I suggest using pattern with fully filled tree outlines, but any other ideas are welcome, for sure.

So, basically, for unknown life cycle outline should be empty; for trees, looking differently through the year - half-filled, for trees, not changing or barely changing its appearance - fully filled.

While not all needle-leaved plants have similar conic shape as fir or cypress (mature pine, for example), in majority of cases, this shape is associated with them pretty well. So, I believe, using conic and rounded canopy outline is legitimate way to show broadleaved and needleleaved trees.

Actually, I have no idea how to show leafless plants - hard to imagine unified symbol for them, they are too different.

@matkoniecz
Copy link
Contributor

leaf_type is covered by #822

@BushmanK
Copy link
Author

I see.
It seems like my idea of empty, half-filled and filled outlines is new.

@pnorman
Copy link
Collaborator

pnorman commented Aug 17, 2015

Closing in favour of #822, as there is substantial overlap.

@pnorman pnorman closed this as completed Aug 17, 2015
@kocio-pl
Copy link
Collaborator

@BushmanK Nice new idea, please tell about it on #822.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 5, 2017

Reopening, because leaf_cycle=* is still not implemented.

Simple try with filling half (semi_/deciduous) or full (semi_/evergreen) areas:

Broadleaved:
broadleaved-deciduous
broadleaved-evergreen

Needleleaved:
needleleaved-deciduous
needleleaved-evergreen

Mixed leaf types:
mixed-deciduous
mixed-evergreen

Unknown leaf types:
unknown-deciduous
unknown-evergreen

@kocio-pl kocio-pl reopened this Sep 5, 2017
@kocio-pl kocio-pl self-assigned this Sep 5, 2017
@kocio-pl kocio-pl added this to the Bugs and improvements milestone Sep 5, 2017
@pnorman
Copy link
Collaborator

pnorman commented Sep 5, 2017

I think this is trying to cram too much non-obvious detail into the symbology

@matthijsmelissen
Copy link
Collaborator

+1

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 5, 2017

Do you think this is just suboptimal solution or leaf_cycle is too much to fit in general style and we should close the issue as wontfix?

@matkoniecz
Copy link
Contributor

Yeah, seconds after reading description at #1756 (comment) I am forgetting meaning of symbols.

I see no reasonable way to show that.

@imagico
Copy link
Collaborator

imagico commented Sep 5, 2017

Keep in mind that rendering leaf_type but not leaf_cycle would bring in a significant amount of additional geographical bias - the almost completely binary distinction of deciduous broadleaved and evergreen needleleaved is something relatively specific to the northern hemisphere temperate zone you all live in. In other parts of earth leaf_cycle is often a much more significant distinction than leaf_type.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 5, 2017

Yeah, seconds after reading description at #1756 (comment) I am forgetting meaning of symbols.

For me it's easy:

  • full filling - leaves always present
  • partial filling - leaves not always present
  • no filling - unknown leaf cycle (as currently rendered, so I didn't repeat it)

It just makes a 9 combinations matrix with leaf types, so it looks like a lot of symbols, but it's just 3x3 (plus leafless as a special case).

@pnorman
Copy link
Collaborator

pnorman commented Sep 7, 2017

Do you think this is just suboptimal solution or leaf_cycle is too much to fit in general style and we should close the issue as wontfix?

wontfix, I just don't see it as possible.

It just makes a 9 combinations matrix with leaf types, so it looks like a lot of symbols, but it's just 3x3 (plus leafless as a special case).

It's better than 9 distinct symbols, but it's still too much. I have other concerns with the details of symbols, but the main one is that it's too much for a general style.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 7, 2017

I guess we should close it now for practical reasons (I see open tickets as worth fixing and this one doesn't look that way). If a more acceptable solutions will ever show up, it can be reopened of course.

@kocio-pl kocio-pl closed this as completed Sep 7, 2017
@kocio-pl kocio-pl added the wontfix-unfeasible Issues closed because of lack of suitable solution label Sep 7, 2017
@imagico imagico changed the title Add rules for leaf_cycle=* and leaf_type=* Differentiate woodland polygon rendering by leaf_cycle Oct 27, 2022
@imagico
Copy link
Collaborator

imagico commented Oct 27, 2022

Reopening this as far as leaf_cycle is concerned because:

  • it was closed for unclear reason (not worth fixing or not feasible fixing).
  • plenty of options to illustrate leaf_cycle in a pattern are known and some have been demonstrated on digital maps - see for example here.
  • as pointed out above in Differentiate woodland polygon rendering by leaf_cycle #1756 (comment) preferentially distinguishing leaf_type rather than leaf_cycle is communicating a significant geographic bias because both the correlation between leaf_type and leaf_cycle and the higher significance of leaf_type in practical differentiation of woodlands is quite specific to the northern hemisphere temperate zone.
  • use of leaf_cycle on woodland polygons has grown a lot since this was closed, it numbers nearly 1 million now - which is more than leaf_type back in 2017. Also percentage of woodland polygons tagged with leaf_cycle has increased quite a lot:
tag 2018 with leaf_cycle percent 2022 with leaf_cycle percent
natural=wood 4.6M 111k 2.4 8.5M 634k 7.5
landuse=forest 3.5M 115k 3.3 5.0M 333k 6.7

@imagico imagico reopened this Oct 27, 2022
@imagico imagico added new features Requests to render new features pattern and removed duplicate wontfix-unfeasible Issues closed because of lack of suitable solution labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
landcover new features Requests to render new features pattern
Projects
None yet
Development

No branches or pull requests

6 participants