-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor docker structure [docker] #2913
Comments
Ready to send a PR. But may I send it into master or you'd create a separate branch for it? |
You can get the idea of the new structure here: |
Sending to master is fine. |
Why is this needed? My docker-compose 1.8.0 (Ubuntu Xenial backport probably) was not able to start building. |
There is no specific reason I can name right now, but docker and docker-compose are still under active development, and using their old versions doesn't seem to be a good idea anyway, so just update them. Update docker-compose (up to v1.17.0)https://docs.docker.com/compose/install/#install-compose or simply:
Update docker (up to v17.09.0)https://docs.docker.com/engine/installation/linux/docker-ce/ubuntu/ |
I know how to do it, but that's not the point (though I have a private policy to use only packages and avoid I think it's better to not add artificial obstacles to not make life harder than it already is (installing Docker might be hard enough for some people). |
@kocio-pl As in your case people may use some outdated versions and you may get some unpredictable results so it's better to force them to update, especially if you use some relatively new software like docker. By using the same updated software (or at least of close versions) you narrow down possible issues. Writing dockerfiles or docker-compose files for "2" is like using openstreetmap-carto v.2.4.0. Lots of bugs have been fixed since then. |
I have no problem with forcing the change when the legacy is a blocker (for example I was advocating dropping TileMill support or support for osm-carto v3). What I don't like is forcing change "just in case". When we bump CartoCSS or Mapnik version dependency it means that we know the older one would not work and this is how I would like to do. |
I think it can be closed now, as #2914 is closed and the code is developed as a separate project. |
Well, let me share my thoughts about how the whole thing can be updated.
scripts/docker-startup.sh
docker-compose.yml
docker-compose.yml
version format to '3.2'.I'm creating a branch in my fork with those changes.
The text was updated successfully, but these errors were encountered: