Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Contrast in medium zoom levels #3513

Open
dieterdreist opened this issue Nov 15, 2018 · 13 comments · May be fixed by #3670
Open

Missing Contrast in medium zoom levels #3513

dieterdreist opened this issue Nov 15, 2018 · 13 comments · May be fixed by #3670

Comments

@dieterdreist
Copy link

dieterdreist commented Nov 15, 2018

Expected behavior

general map that gives indications about the place

Actual behavior

road focused

Links and screenshots illustrating the problem

Here some example comparisons between osm-carto and the geofabrik fork, look how the forests are important to understand the structure of the landscape and how they are missing in current osm-carto, until zoom 13 when they become visible but when the scale is so low that you cannot see the bigger picture any more:

Zoom 8

Zoom 8

Zoom 9

Zoom 9

Zoom 10

Zoom 10

Zoom 11

Zoom 11

Zoom 12

Zoom 12

Zoom 13

Zoom 13

color fading was an interesting experiment, but in the end it seems the results are worse with the fading than without.

@kocio-pl kocio-pl added this to the Bugs and improvements milestone Nov 15, 2018
@kocio-pl
Copy link
Collaborator

My opinion with this experiment is that it works better than other maps. If all the elements are strong, it's making visual mess, especially when the shapes are not simplified and averaged (small elements make noise). In fact we loose some contrast then, because there is less difference between elements (the difference between - say - 10 and 100 is bigger than between 90 and 100).

However fading might be not that fast - it needs some testing to find good balance.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Nov 15, 2018 via email

@kocio-pl
Copy link
Collaborator

I don't follow this fork closely, but I like the idea of generalized green for high/medium/low vegetation very much and after merging #3327 we have main green colors the same as in @imagico fork, so we can go further in this direction.

Unfortunately demo map is limited to z9, so we can't see the difference on all the midzoom levels (z10-z11). But I think this still has some visual problems when there are many small patches of green (especially dark green) and some fading might help - Moscow area example:

http://maps.imagico.de/#map=9/55.766/37.711&lang=en&r=osmlz&o=aa&ui=2

screenshot_2018-11-15 imagico de maps 1

It seems however that dark green (for high vegetation) is changed for something lighter, so it needs more attention anyway, but is promising - the same area using (probably) our current forest/wood green without fading (some other colors are not up to date) looks worse:

http://maps.imagico.de/#map=9/55.766/37.711&lang=en&r=osmlz&o=ea&ui=2

screenshot_2018-11-15 imagico de maps 2

Another issue is where to draw the line between showing all greens and generalized vegetation greens, because we still want to show specific green areas from some zoom level.

There are also other changes - motorways are turned into violet ( http://blog.imagico.de/more-new-colors/ ), which was possible after border color change into something else - I like both these changes, but it needs even more testing and separate tickets to discuss them.

@jeisenbe
Copy link
Collaborator

FYI, the low-zoom colors on Imagico's alt-colors fork are:

@built-up-lowzoom: #d7d4d3;
@vegetation-tall-lowzoom: #b6dca6;
@vegetation-low-lowzoom: #ddecbd;
@bare_ground-lowzoom: #efe7d9;

Compare to:

@grass: #cdebb0;
@scrub: #b5e3b5;
@forest: #add19e;  
...
@residential: #e0dfdf; 
...
@bare_ground: #eee5dc;

So they are all adjusted compared to the high-zoom colors.

This is based off of the repository on GitHub, https://github.com/imagico/osm-carto-alternative-colors/tree/master

Vegetation-low includes:
picnic_site, caravan_site, camp_site,
grave_yard, cemetery,
park, recreation_ground, dog_park, golf_course, miniature_golf,
allotments, farmland, greenhouse_horticulture
meadow/grassland/grass, village_green, common, garden,
heath, bog, string_bog, wet_meadow, fen, marsh

Vegetation-tall includes:
vineyard, orchard, plant_nursery,
wood, forest, scrub, swamp

Bare_ground:
quarry, landfill,
bare_rock, scree, shingle, sand
beach, shoal,

Built-up:
residential, retail, industrial, commercial,
garages, farmyard, railway, construction, brownfield
power station/generator/substation
hospital, clinic, university, college, school, kindergarten
parking, aeroway=apron, aerodrome,
highway=services, rest_area
railway=station
fitness_center, sports_center, stadium, track, pitch

I notice that mangroves were left out; I would probably include these under vegetation_tall, and I would also like to give mangroves the new scrub color as a background, once it is decided.

@imagico
Copy link
Collaborator

imagico commented Nov 20, 2018

I notice that mangroves were left out

Mangroves are not rendered with a fill color in either OSM-Carto or ac-style.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Nov 20, 2018 via email

@jeisenbe
Copy link
Collaborator

Related to #3647

As discussed, the three ways to fix this issue are:

  1. Remove the landcover fading, and render all landcovers at full strength up to their new limits (z5 for forest, meadow, scrub, heath, farmland, wetland etc).
  • This option is followed by the French branch
  1. Change the fading to take place at a higher level, say z7 to z5. This would give the landcover the appearance of "fading out" right before it disappears at z4, which is similar to what is done on some other maps. z8 to z12 would now be in full color.
  • This could also be done somewhat sooner, say z10 to z8, so that z11 and z12 would show still show the full strength colors.
  1. Use a reduced set of colors at low zoom, combining different types of vegetation into high and low vegetation, and showing all developed land the same. We already do the latter at mid-zoom with developed land. This is the method used by @imagico in the alternative-colors branch: eg http://maps.imagico.de/#map=9/55.766/37.711&lang=en&r=osmlz&o=aa&ui=2
  • If the forest color is still too dark in this example, we could try something lighter. It's not possible to render the forest color much lighter, or to shift the hue much, when scrub and orchards rendered differently, but with all of these combined in one color there are many options.

Would some examples of 3) at z10 thru z12 be helpful?

@kocio-pl
Copy link
Collaborator

I am not sure if combining is what really helps here and if it's needed (it's always better to show the differences by default). I see the difference between forest colors in #3513 (comment) and this might be more important factor.

Using current OSM Carto color layer (without fading) and Gpicker wood is #ADD19D (close to #ADD19E - maybe some small Firefox display error?):

http://maps.imagico.de/#map=9/55.722/37.672&lang=en&r=osmlz&o=ea&ui=2

while using alternative colors layer it's much better #B6DCA5:

http://maps.imagico.de/#map=9/55.722/37.672&lang=en&r=osmlz&o=aa&ui=2

which seems to be close to the vegetation-tall-lowzoom defined as #b6dca6 here (probably the same small display error in browser):

https://github.com/imagico/osm-carto-alternative-colors/blob/441d59909d3dd548731789fec9d75200ee606023/landcover.mss#L76-L84

I would check first if changing woods/forest color to #b6dca6 is not enough on mid/low zoom and how does it work on high zoom.

@imagico
Copy link
Collaborator

imagico commented Jan 23, 2019

Two comments here:

This option is followed by the French branch

The french style is not rendering low zoom landcover with mapnik, it uses a pre-rendered image that is scaled to the zoom level in question:

https://github.com/cquest/osmfr-cartocss/blob/master/osmfr.yml#L84-L90
#2654 (comment)

And the one bit mismatch in colors in the low zoom demo is due to some rounding error in color space conversion in the renderer.

@kocio-pl
Copy link
Collaborator

I made some initial preview with rough replacing current forest/woods color with vegetation-tall-lowzoom color value (without tuning anything else, like pattern color or changing heath color) and it still looks interesting to me. What do you think about it as a starting point?

1. The contrast with water is smaller (but still acceptable):

a) low zoom water areas

http://maps.imagico.de/#map=9/62.656/27.482&lang=en&r=osmlz&o=de&ui=2 - before

screenshot_2019-01-24 imagico de maps

http://maps.imagico.de/#map=9/62.656/27.482&lang=en&r=osmlz&o=9e&ui=2 - after

screenshot_2019-01-24 imagico de maps 1

b) high zoom water lines

https://www.openstreetmap.org/#map=15/51.8588/21.3818

Before

screenshot_2019-01-24 openstreetmap carto kosmtik

After

screenshot_2019-01-24 openstreetmap carto kosmtik 1

2. Better contrast with cemetery

Before

screenshot_2019-01-24 openstreetmap carto kosmtik 2

After

screenshot_2019-01-24 openstreetmap carto kosmtik 3

3. Worse contrast with current allotments

https://www.openstreetmap.org/#map=14/52.3007/21.0681

Before

screenshot_2019-01-24 openstreetmap carto kosmtik 4

After

screenshot_2019-01-24 openstreetmap carto kosmtik 5

4. Worse contrast with current scrubs

https://www.openstreetmap.org/#map=17/52.13467/21.08249

Before

screenshot_2019-01-24 openstreetmap carto kosmtik 6

After

screenshot_2019-01-24 openstreetmap carto kosmtik 7

5. Worse contrast with current heath

https://www.openstreetmap.org/#map=17/52.15141/21.25455

Before

screenshot_2019-01-24 openstreetmap carto kosmtik 8

After

screenshot_2019-01-24 openstreetmap carto kosmtik 9

6. Good enough contrast with current grass and farmlands, more balanced for different small vegetation patches

https://www.openstreetmap.org/#map=15/52.0971/21.0927

Before

screenshot_2019-01-24 openstreetmap carto kosmtik 10

After

screenshot_2019-01-24 openstreetmap carto kosmtik 11

7. Less aggressive for parks and residential areas

https://www.openstreetmap.org/#map=16/52.2666/20.9920

Before

screenshot_2019-01-24 openstreetmap carto kosmtik 12

After

screenshot_2019-01-24 openstreetmap carto kosmtik 13

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jan 24, 2019 via email

@Adamant36
Copy link
Contributor

I think it looks good. Especially with residential. I don't see the issue with scrub either. Although it could be my monitor. Heath and allotments do look worse though, but its not like those can't be tweaked.

@jeisenbe
Copy link
Collaborator

Problem 8.: another issue with#b6dca6 for woodland/forest at high zoom is that orchard/vineyard color is #aedfa3; - these are very similar.

#b6dca6 is Lch(84,32,135) and #aedfa3; is Lch(84,35,138) - so the lightness is identical, the hue is almost the same, and the chroma is very close.

This is probably one of the reasons why @imagico merged the orchard and forest colors at low zoom.

Here's a test rendering of Southern Australia (near Adelaide), where there are many vineyards and some areas of forest:

https://www.openstreetmap.org/#map=12/-34.6493/138.9740
Master (current rendering) z12
z12-s-aus-master

z12 Without fading (also same as alt-colors style landcover at this zoom level)
z12-s-aus-nofade

z12 Forest #b6dca6
z12-s-aus-nofade-forest

  • Very hard to see a difference between vineyard and forest

Master z11
z11-s-aus-master-12 -34 6493 138 9740

z11 Without fading
z11-s-aus-nofade

z11 Forest #b6dca6
z11-s-aus-nofade-forest

z11 Alt-colors for landcover

  • There are 4 landcover colors: tall vegetation, low vegetation, bare ground, and developed land
    z11-s-aus-altcolors

Master z10
z10-s-aus-master

z10 Without fading
z10-s-aus-nofade

z10 Forest #b6dca6
z10-s-aus-nofade-forest

z10 Alt-colors for landcover
z10-s-aus-altcolors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants