-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Contrast in medium zoom levels #3513
Comments
My opinion with this experiment is that it works better than other maps. If all the elements are strong, it's making visual mess, especially when the shapes are not simplified and averaged (small elements make noise). In fact we loose some contrast then, because there is less difference between elements (the difference between - say - 10 and 100 is bigger than between 90 and 100). However fading might be not that fast - it needs some testing to find good balance. |
Imagico has shown an alternative where the classes of land use and natural
areas are combined, so you have darker green for high vegetation (forest,
scrub etc), pale green for low vegetation (heath, grass, pasture...), and
gray for developed land (residential thru retail).
By having fewer different colors at the low zoom level the map is more
readable, even without fading.
…On Thu, Nov 15, 2018 at 8:46 PM kocio-pl ***@***.***> wrote:
My opinion with this experiment is that it works better than other maps.
If all the elements are strong, it's making visual mess, especially when
the shapes are not simplified and averaged (small elements make noise). In
fact we loose some contrast then, because there is less difference between
elements (the difference between - say - 10 and 100 is bigger than between
90 and 100).
However fading might be not that fast - it needs some testing to find good
balance.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3513 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshOAZ9XuLUg_cS43ISA_b07h7WAZCks5uvVQOgaJpZM4YfhW->
.
|
I don't follow this fork closely, but I like the idea of generalized green for high/medium/low vegetation very much and after merging #3327 we have main green colors the same as in @imagico fork, so we can go further in this direction. Unfortunately demo map is limited to z9, so we can't see the difference on all the midzoom levels (z10-z11). But I think this still has some visual problems when there are many small patches of green (especially dark green) and some fading might help - Moscow area example: http://maps.imagico.de/#map=9/55.766/37.711&lang=en&r=osmlz&o=aa&ui=2 It seems however that dark green (for high vegetation) is changed for something lighter, so it needs more attention anyway, but is promising - the same area using (probably) our current forest/wood green without fading (some other colors are not up to date) looks worse: http://maps.imagico.de/#map=9/55.766/37.711&lang=en&r=osmlz&o=ea&ui=2 Another issue is where to draw the line between showing all greens and generalized vegetation greens, because we still want to show specific green areas from some zoom level. There are also other changes - motorways are turned into violet ( http://blog.imagico.de/more-new-colors/ ), which was possible after border color change into something else - I like both these changes, but it needs even more testing and separate tickets to discuss them. |
FYI, the low-zoom colors on Imagico's alt-colors fork are:
Compare to:
So they are all adjusted compared to the high-zoom colors. This is based off of the repository on GitHub, https://github.com/imagico/osm-carto-alternative-colors/tree/master Vegetation-low includes: Vegetation-tall includes: Bare_ground: Built-up: I notice that mangroves were left out; I would probably include these under vegetation_tall, and I would also like to give mangroves the new scrub color as a background, once it is decided. |
Mangroves are not rendered with a fill color in either OSM-Carto or ac-style. |
Right, I’m suggesting that they could get a fill in the future, similar to
swamp.
But many (most?) mangroves are closer to scrub in height, so the color
could be the same as that used for scrub; this would also help distinguish
swamp and mangroves
…On Tue, Nov 20, 2018 at 8:28 PM Christoph Hormann ***@***.***> wrote:
I notice that mangroves were left out
Mangroves are not rendered with a fill color in either OSM-Carto or
ac-style.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3513 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshOoeCCsu1Dtl7MGv9IZQf4fPt8Anks5uw-dFgaJpZM4YfhW->
.
|
Related to #3647 As discussed, the three ways to fix this issue are:
Would some examples of 3) at z10 thru z12 be helpful? |
I am not sure if combining is what really helps here and if it's needed (it's always better to show the differences by default). I see the difference between forest colors in #3513 (comment) and this might be more important factor. Using current OSM Carto color layer (without fading) and Gpicker wood is http://maps.imagico.de/#map=9/55.722/37.672&lang=en&r=osmlz&o=ea&ui=2 while using alternative colors layer it's much better http://maps.imagico.de/#map=9/55.722/37.672&lang=en&r=osmlz&o=aa&ui=2 which seems to be close to the I would check first if changing woods/forest color to |
Two comments here:
The french style is not rendering low zoom landcover with mapnik, it uses a pre-rendered image that is scaled to the zoom level in question: https://github.com/cquest/osmfr-cartocss/blob/master/osmfr.yml#L84-L90 And the one bit mismatch in colors in the low zoom demo is due to some rounding error in color space conversion in the renderer. |
I made some initial preview with rough replacing current forest/woods color with vegetation-tall-lowzoom color value (without tuning anything else, like pattern color or changing heath color) and it still looks interesting to me. What do you think about it as a starting point? 1. The contrast with water is smaller (but still acceptable): a) low zoom water areas http://maps.imagico.de/#map=9/62.656/27.482&lang=en&r=osmlz&o=de&ui=2 - before http://maps.imagico.de/#map=9/62.656/27.482&lang=en&r=osmlz&o=9e&ui=2 - after b) high zoom water lines https://www.openstreetmap.org/#map=15/51.8588/21.3818 Before After 2. Better contrast with cemetery Before After 3. Worse contrast with current allotments https://www.openstreetmap.org/#map=14/52.3007/21.0681 Before After 4. Worse contrast with current scrubs https://www.openstreetmap.org/#map=17/52.13467/21.08249 Before After 5. Worse contrast with current heath https://www.openstreetmap.org/#map=17/52.15141/21.25455 Before After 6. Good enough contrast with current grass and farmlands, more balanced for different small vegetation patches https://www.openstreetmap.org/#map=15/52.0971/21.0927 Before After 7. Less aggressive for parks and residential areas https://www.openstreetmap.org/#map=16/52.2666/20.9920 Before After |
Points 3, 4, and 5 (worse contrast with scrub, heath, allotments) are
serious problems.
This is not a problem at mid to low zoom level in the alt-colors branch,
where heath and allotments are merged with grass and farmland, and scrub is
merged with forest.
…On Thu, Jan 24, 2019 at 10:22 AM kocio-pl ***@***.***> wrote:
I made some initial preview with rough replacing current forest/woods
color with vegetation-tall-lowzoom color value (without tuning anything
else, like pattern color or changing heath color) and it still looks
interesting to me. What do you think about it as a starting point?
*1. The contrast with water is smaller (but still acceptable):*
*a) low zoom water areas*
http://maps.imagico.de/#map=9/62.656/27.482&lang=en&r=osmlz&o=de&ui=2 -
before
[image: screenshot_2019-01-24 imagico de maps]
<https://user-images.githubusercontent.com/5439713/51646572-622b0080-1f79-11e9-8856-e666b9f92f49.png>
http://maps.imagico.de/#map=9/62.656/27.482&lang=en&r=osmlz&o=9e&ui=2 -
after
[image: screenshot_2019-01-24 imagico de maps 1]
<https://user-images.githubusercontent.com/5439713/51646583-740ca380-1f79-11e9-9cff-c30b897e8592.png>
*b) high zoom water lines*
https://www.openstreetmap.org/#map=15/51.8588/21.3818
Before
[image: screenshot_2019-01-24 openstreetmap carto kosmtik]
<https://user-images.githubusercontent.com/5439713/51646704-fb5a1700-1f79-11e9-832c-653fb5b91968.png>
After
[image: screenshot_2019-01-24 openstreetmap carto kosmtik 1]
<https://user-images.githubusercontent.com/5439713/51646715-01e88e80-1f7a-11e9-92da-c18540b13dd4.png>
*2. Better contrast with cemetery*
Before
[image: screenshot_2019-01-24 openstreetmap carto kosmtik 2]
<https://user-images.githubusercontent.com/5439713/51646860-a8349400-1f7a-11e9-9a05-05d37364cf30.png>
After
[image: screenshot_2019-01-24 openstreetmap carto kosmtik 3]
<https://user-images.githubusercontent.com/5439713/51646865-aec30b80-1f7a-11e9-81fb-cdbfa4ea6467.png>
*3. Worse contrast with current allotments*
https://www.openstreetmap.org/#map=14/52.3007/21.0681
Before
[image: screenshot_2019-01-24 openstreetmap carto kosmtik 4]
<https://user-images.githubusercontent.com/5439713/51646968-22651880-1f7b-11e9-9c57-bb849cafd2de.png>
After
[image: screenshot_2019-01-24 openstreetmap carto kosmtik 5]
<https://user-images.githubusercontent.com/5439713/51646970-2729cc80-1f7b-11e9-9672-d15e80636ea5.png>
*4. Worse contrast with current scrubs*
https://www.openstreetmap.org/#map=17/52.13467/21.08249
Before
[image: screenshot_2019-01-24 openstreetmap carto kosmtik 6]
<https://user-images.githubusercontent.com/5439713/51647111-c2bb3d00-1f7b-11e9-8a92-19b8e9819153.png>
After
[image: screenshot_2019-01-24 openstreetmap carto kosmtik 7]
<https://user-images.githubusercontent.com/5439713/51647118-c8b11e00-1f7b-11e9-93af-c7c85d44c7ad.png>
*5. Worse contrast with current heath*
https://www.openstreetmap.org/#map=17/52.15141/21.25455
Before
[image: screenshot_2019-01-24 openstreetmap carto kosmtik 8]
<https://user-images.githubusercontent.com/5439713/51647268-6278cb00-1f7c-11e9-92fd-0dcd0434e58d.png>
After
[image: screenshot_2019-01-24 openstreetmap carto kosmtik 9]
<https://user-images.githubusercontent.com/5439713/51647274-66a4e880-1f7c-11e9-8947-4ade30c9a79b.png>
*6. Good enough contrast with current grass and farmlands, more balanced
for different small vegetation patches*
https://www.openstreetmap.org/#map=15/52.0971/21.0927
Before
[image: screenshot_2019-01-24 openstreetmap carto kosmtik 10]
<https://user-images.githubusercontent.com/5439713/51647424-0c585780-1f7d-11e9-8cee-63c0dbe22386.png>
After
[image: screenshot_2019-01-24 openstreetmap carto kosmtik 11]
<https://user-images.githubusercontent.com/5439713/51647430-124e3880-1f7d-11e9-84a3-b3285d72cfbf.png>
*7. Less aggressive for parks and residential areas*
https://www.openstreetmap.org/#map=16/52.2666/20.9920
Before
[image: screenshot_2019-01-24 openstreetmap carto kosmtik 12]
<https://user-images.githubusercontent.com/5439713/51647666-031bba80-1f7e-11e9-9579-a049b5275658.png>
After
[image: screenshot_2019-01-24 openstreetmap carto kosmtik 13]
<https://user-images.githubusercontent.com/5439713/51647675-09119b80-1f7e-11e9-9220-68f6cd1c268a.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3513 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshMgV_BN5wUHoo3pH4ha3e92fCz9Yks5vGQrggaJpZM4YfhW->
.
|
I think it looks good. Especially with residential. I don't see the issue with scrub either. Although it could be my monitor. Heath and allotments do look worse though, but its not like those can't be tweaked. |
Problem 8.: another issue with
This is probably one of the reasons why @imagico merged the orchard and forest colors at low zoom. Here's a test rendering of Southern Australia (near Adelaide), where there are many vineyards and some areas of forest: https://www.openstreetmap.org/#map=12/-34.6493/138.9740 z12 Without fading (also same as alt-colors style landcover at this zoom level)
z11 Alt-colors for landcover |
Expected behavior
general map that gives indications about the place
Actual behavior
road focused
Links and screenshots illustrating the problem
Here some example comparisons between osm-carto and the geofabrik fork, look how the forests are important to understand the structure of the landscape and how they are missing in current osm-carto, until zoom 13 when they become visible but when the scale is so low that you cannot see the bigger picture any more:
Zoom 8
Zoom 9
Zoom 10
Zoom 11
Zoom 12
Zoom 13
color fading was an interesting experiment, but in the end it seems the results are worse with the fading than without.
The text was updated successfully, but these errors were encountered: