Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust hue of landuse=residential #1202

Closed
wants to merge 1 commit into from

Conversation

nebulon42
Copy link
Contributor

This tries to make the new building colour look better on landuse=residential.

  • It darkens the building outline by 5% for better contrast.
  • It gives residential colour the same hue as buildings and lightens it a bit.
  • To compensate for that the outline is a bit stronger and is rendered already at z15.
  • At z17 residential colour is lightened up a bit by 2% to have more contrast with buildings, while keeping it recognisable at lower zoom levels.

Drawbacks: residential colour is now more similar to aerodrome colour, but they were not that different before. I propose to adjust aerodrome colour if they are too similar.

bildschirmfoto vom 2015-01-06 18 55 26

http://www.openstreetmap.org/#map=15/48.0804/16.6021
before z15
residenital_aerodrome_before_z15
(aerodrome left, residential right)

http://www.openstreetmap.org/#map=17/48.17157/16.39569
before z17
residential_before_z17

after z15
residential_aerodrome_after_2_z15
(aerodrome left, residential right)

after z17
residential_after_2_z17

@matthijsmelissen
Copy link
Collaborator

Looks fine to me, what does @pnorman think?

@pnorman
Copy link
Collaborator

pnorman commented Jan 6, 2015

We had decided to keep the lightness of residential, retail, commercial, industrial, and farmland the same. This would reverse that decision, which I don't think is a good idea.

@nebulon42
Copy link
Contributor Author

I could try to extend this PR to the other landuses you mentioned, it would be good to make them lighter anyway. I'm not sure if it is possible, consistency could be also achieved by not strictly adhering to the numbers. It is good to have some symmetry in colours though.

But very practically speaking: We have here overlaying features with low contrast. How should we deal with them?

@pnorman
Copy link
Collaborator

pnorman commented Jan 6, 2015

would be good to make them lighter anyway.

We made them a lot lighter in #599. I'd rather not go even lighter.

But very practically speaking: We have here overlaying features with low contrast. How should we deal with them?

We should make those features stand out more, either with decreased lightness, increased chroma, or suitable outlines for linear features.

@matthijsmelissen
Copy link
Collaborator

Of course, making the buildings slightly darker then they are now is also not out of the question as far as I'm concerned.

@nebulon42
Copy link
Contributor Author

I'd rather not go even lighter.

Also not for forest? There is this issue with trunk roads. Farmyard is also much too saturated. I first thought making the buildings lighter was intended to be the first step in desaturating the map (even further).

We should make those features stand out more, either with decreased lightness, increased chroma, or suitable outlines for linear features.

So let's assume the landuse colour should not change. Then I suggest that the building outlines should be 10% darker than they currently are. Also I think it's the yellowish hue of the buildings that does not go so well with the landuse colours. Here I moved the hue a bit into red and also darkened the outlines by 20% from that.

Starting from HSV(39°, .07, .84).
bildschirmfoto vom 2015-01-06 22 05 13

This is HSV(30°, .07, .84) (more red).
residential_before_2_z17

This is HSV(25°, .07, .84) (still more red).
more_red

with some farmland
farmland

This is HSV(20°, .07, .84) (even more red).
even_more_red

Old building colours for comparison.
building_old

This could work (I like the second one with 30° best). What do you think?

@mboeringa
Copy link

I am perfectly OK with even the last variant: HSV(20°, .07, .84) (even more red). It is still far from pink, but seems to give the buildings a bit more "body", without making them significantly darker.

@nebulon42
Copy link
Contributor Author

I'm closing this as there is currently no approvement for adjusting landuse colours. I will open a new PR concerned with tweaking the building hue.

@nebulon42 nebulon42 closed this Jan 8, 2015
@nebulon42 nebulon42 deleted the residential-hue branch January 8, 2015 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants