-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
path/footway/cycleway - render missing surface separately, more prominent rendering for unpaved ways #1788
Conversation
Should we address the big difference in strength of footway and cycleway colour in this PR? The original colour was defined as "salmon" so I don't think much thought was given to it at the time. |
It is already addressed by making cycleway less wide. I calibrated it with goal of making cycleways slightly more prominent than footways. Widths are conveniently displayed at beginning of matkoniecz@5a4089f |
First thanks for working on this. I think this suggestion is an improvement on both the semantics (i.e. having a third class) and for readability compared to the current state. IMO however
My assessment regarding your goals:
In total i would be for merging this to address #1766 but would consider further improvements to be highly desirable. Is there a particular reason why you don't want to use a solid line for paved? It would directly match the styling used for tracks so it should be fairly intuitive for the map user. |
I agree. In that case (unlike say #1736) I ended work not because I was happy about results but because I run out of ideas and time. It results in improvements - so I submitted PR, but hopefully somebody will find way to further improve situation.
I tried it in the past and the best ones were described at https://www.openstreetmap.org/user/Mateusz%20Konieczny/diary/35351 I also tried again to use solid red line and results were worse than what is in this PR. There were for example big problems with "keep footway style less prominent than highway=tracks", "avoid making paved footways more prominent". Idea of solid lines for footways seems great until I start trying to really use it - typically the worst problems are in area with heavy footway density (cities with mapped footways). |
Is it about all zoom levels? Or is it now affecting only some of them? |
I must say i did not check it a lot but the styling i tried which apart from the color is not unlike the purple variant in your diary entry seems to work pretty decently, see here: Note this could of course use some lightening on the solid lines and in particular stairs but also note how it is not really stronger than the unmodified cycleways.
z<=14 is a different story of course - with different problems (#1748), for z15+ it seems so improve a bit with higher zoom levels. But all the differences are really small, both between the different zoom levels and different line types. You put a lot of work in here through fine tuning widths but I really think the color is largely to blame. |
Problems appear on lower zoom levels - either footways are too strong (especially compared too tracks) or invisible on some landuses or there is a jarring jump from dots to solid line. Though it is likely that I really missed something that would work or I am disliking more than others sudden changes in rendering on changing zoom levels (I think that I am the only person complaining about too significant changes as zoom level changes). |
I don't see this - could you give an example? |
I have no code to immediately reproduce (I checked some possibilities and immediately discarded all attempts, without saving as separate branches). I was testing in http://www.openstreetmap.org/#map=15/50.0565/19.8624 for track prominence and used http://www.openstreetmap.org/#map=15/50.0875/20.0114 for problem of fully mapped footways. z14, z15 was the most problematic.
It typically failed either at http://www.openstreetmap.org/#map=19/50.09125/19.90067 or http://www.openstreetmap.org/#map=18/50.05925/19.91189 made obvious that there is too much of casing and on natural=bare_rock it will fail completely.
happens everywhere |
On doing it again to recreate irritating issues I noticed that I was using the same width for all types. It seems that tweaking widths separately may give better results - so maybe there will be an alternative with solid line. |
I probably really should expect this problem. Solid line for paved footways results in solid line for paved cycleways. Cycleways that are blue, resulting in a game "is it a ditch or a cycleway"? Code (maybe someone has an idea how to solve this or is not considering it as a problem - footways are better than in this PR but not so good to justify lack of consistency with cycleways): https://github.com/matkoniecz/openstreetmap-carto/commits/solid Therefore I keep this PR as my proposal. |
Yes, that is probably the major reason why the cycleway blue was so heavy in the first place. But i am not so sure if it is that much of a problem, after all we also have dashed waterways and the cycleway blue is very different from the waterway blue and could be even moved somewhat towards violet, something like #5020ff. |
I'm inclined to merge as-is, considering it's an improvement. Still need to do some more local review. |
path/footway/cycleway - render missing surface separately, more prominent rendering for unpaved ways
should we release a new version to avoid more outdated discussion? |
I hope to release later today, after #1791 |
I have trouble assessing the three buckets since the styles are not described and the examples are not annotated. |
It changes rendering for highway=path/footway/cycleway.
Now there are three buckets*:
There are contradictory goals that I tried to satisfy:
I think that it is works fairly well (or at least better than currently and previously used style).
Footways are still too dominant in fully mapped cities, important walking routes are not visible enough, paved/unknown/unpaved are not different enough etc. But it is near limits of useing the same style used across the world (yes, there is currently no available method to display [highway=path, surface=unpaved] differently depending whatever it is an unimportant path in crowded park or the main route across the mountains).
*Yes, this link leads to comment that is worth reading.
Examples for cities:
https://cloud.githubusercontent.com/assets/899988/9492585/18a7c242-4bf9-11e5-948c-2b9460eb48fe.png
https://cloud.githubusercontent.com/assets/899988/9492587/18aae9ea-4bf9-11e5-9455-bd627c5529da.png
https://cloud.githubusercontent.com/assets/899988/9492588/18ab11fe-4bf9-11e5-99ac-59786f54a2ab.png
https://cloud.githubusercontent.com/assets/899988/9492586/18aab8c6-4bf9-11e5-850a-227b50635331.png
Outside cities:
https://cloud.githubusercontent.com/assets/899988/9492602/404eaa72-4bf9-11e5-9189-bab5509794c3.png
https://cloud.githubusercontent.com/assets/899988/9492603/40520c4e-4bf9-11e5-8628-30ab33d54d93.png
https://cloud.githubusercontent.com/assets/899988/9492604/4079d972-4bf9-11e5-96ab-398d551f8619.png
https://cloud.githubusercontent.com/assets/899988/9492605/40fb4bd8-4bf9-11e5-8280-324af165b9c1.png
fixes #1765 and #1766
BTW, for people interested in adding surface tags in their area - here is a helpful overpass query (zoom in before using "Run" button): http://overpass-turbo.eu/s/b88 This query return ways without surface tags and ones tagged with tags not documented as valid surface valies for highway=footway/path/cycleway (in nearly fully mapped regions one may start mapping also surface for other highway types).