Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Mapnik 3 in install docs #1792

Merged
merged 1 commit into from
Aug 28, 2015
Merged

Conversation

pnorman
Copy link
Collaborator

@pnorman pnorman commented Aug 27, 2015

There are no known major Mapnik 3 issues left.

After merging, I'll have a look at the issues against the Mapnik 3 milestone. Those which will require Mapnik 3 style features can be left, but others can be closed.

There are no known major Mapnik 3 issues left.
@matkoniecz
Copy link
Contributor

#1579 is closed but "Text is farther away from lines" and "maxzoom depreciated and will be removed in 4.x spams the log(...)" are not marked as solved. First problem is in the section "Major issues".

Also, it seems that according to mapnik/mapnik#2913 we still need add vertical-alignment:middle to labels on lines using offsets.

@pnorman
Copy link
Collaborator Author

pnorman commented Aug 27, 2015

#1579 is closed but "Text is farther away from lines" and "maxzoom depreciated and will be removed in 4.x spams the log(...)" are not marked as solved. First problem is in the section "Major issues".

I don't plan to fix the max/min zoom stuff anytime soon, because it's a minor issue.

When I last did a review, I couldn't see any other problems.

matkoniecz added a commit that referenced this pull request Aug 28, 2015
Support Mapnik 3 in install docs
@matkoniecz matkoniecz merged commit c50164c into gravitystorm:master Aug 28, 2015
@pnorman pnorman deleted the mapnik3 branch October 12, 2015 00:17
@matthijsmelissen
Copy link
Collaborator

I have been exclusively using Mapnik 3 in Kosmtik for a couple of months, and I haven't encountered any issues.

What would be the next step? Are we ready to recommend the server admins to move to Mapnik 3?

@gravitystorm
Copy link
Owner

Sounds great to me. I've opened a ticket at openstreetmap/chef#39

This should allow us to "fix" various text-rendering issues. I'm also happy to require mapnik3 at any point - we'll just need to bump the version number when we start using mapnik3-only features.

@matthijsmelissen
Copy link
Collaborator

Just to be clear, I haven't tested exhaustively on possible Mapnik 3 issues - I just haven't encountered any while doing development.

So I guess we shouldn't be too surprised if some issues pop up anyway.

@gravitystorm
Copy link
Owner

Don't worry, I carefully hedged my statement on that issue :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants