Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topographic extensions #2134

Closed
wants to merge 6 commits into from
Closed

Conversation

Ircama
Copy link
Contributor

@Ircama Ircama commented May 28, 2016

Added rendering of valleys, ridges and glaciers.
Revised zooms for some elements.
Revised openstreetmap-carto.style (and project.yaml) to support a future update to roads.mss (under dev now)
Added scripts\updatemml.py which makes project.mml compatible with Tilemill (run first scripts\yaml2mml.and then scripts\updatemml.py)
Added scripts\get-shapefiles.py which performs the same as get-shapefiles.sh, exploiting in Python 2.7

Revised zooms for some elements.
Revised openstreetmap-carto.style (and project.yaml) to support a future update to roads.mss (under dev now)
Added updatemml.py which performs the same as get-shapefiles.sh, exploiting in Python 2.7
@mboeringa
Copy link

Looking at a couple of the changes, especially the changes to zoomlevels for certain features, I think this PR needs proper visual validation in different parts of the world. While rendering some of the stuff like amenity=drinking_water from Z14 may be possible in sparsely populated mountain regions, some of these changes could add a lot of clutter in others, like urban areas. Simply changing symbol size (smaller) to forestall problems may sometimes work, but definitely not always...

@HolgerJeromin
Copy link
Contributor

This pr should be split into some pulls.
The sac_scale changes are at least be implemented later and different after the style uses hstore

@Ircama
Copy link
Contributor Author

Ircama commented May 29, 2016

@mboeringa: we definitively need to ensure rendering compatibility with urban areas; nevertheless, the AS IS configuration needs many improvements to provide a decent quality also in mountain territories; I can anyway reconsider the original zoom for amenity=drinking_water and revise natural=spring instead.

@HolgerJeromin: I will revert my pool request and provide separate pools; one for zooms, another for management of valleys/ridges/glaciers, one for updatemml.py script. I then tested hstore and does work (tags->'sac_scale'::text AS sac_scale), so I’ll provide a project.yaml supporting hstore with a separate pool.

@Ircama Ircama closed this May 29, 2016
@Ircama Ircama reopened this May 29, 2016
…mml.py) in order to update project.mml with the appropriate "dbname", "bounds" and "center" parameters for Tilemill.

E.g.,

Edit updatemml.py to update the "START CONFIG "/"END CONFIG" section with preferred bounds, wished default center and appropriate dbParms data.

run

scripts\yaml2mml.py && scripts\updatemml.py

after changing project.yaml in order to produce a project.mml file ready to be opened with Tilemill.

This script has been tested on Windows.
@Ircama
Copy link
Contributor Author

Ircama commented May 30, 2016

As per request, this branch has been substituted with #2136, #2137, #2138, #2139.
Please, let me know whether I have to close or remove it, thanks.

@pnorman pnorman closed this May 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants