Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plant_nursery as same render as green_greenhouse_horticulture #2304

Closed
wants to merge 1 commit into from

Conversation

geostonemarten
Copy link

fix issue #1772

@imagico
Copy link
Collaborator

imagico commented Aug 25, 2016

This essentially means rendering it like farmland.

Have you considered the suggestion to render it as a pattern variation of orchard?

Technically you should have all changes in one PR and modify project.yaml and then generate project.mml.

@geostonemarten
Copy link
Author

@imagico I have create other path for these others files but continus integration reject its... I fork master project to create a full path.

Have you considered the suggestion to render it as a pattern variation of orchard?

I don't see this suggestion but i think plant_nursery is most similar to green_greenhouse_horticulture than orchard

For this time there is no render. We can change it last time.

@imagico
Copy link
Collaborator

imagico commented Aug 25, 2016

You can push your yaml/mml changes to the geostonemarten:patch-1 branch and it will be automatically added to this PR. You need to change the yaml and then call yaml2mml.py to generate the mml - otherwise the automatic checks will indicate an error.

I don't see this suggestion but i think plant_nursery is most similar to green_greenhouse_horticulture than orchard

See #1772 (comment)

plant_nursery is often closer to orchard than to farmland on various levels so it might be a better way to render it.

@geostonemarten geostonemarten deleted the patch-1 branch August 25, 2016 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants