Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jewish symbols made lighter #2761

Merged
merged 1 commit into from
Aug 22, 2017
Merged

Jewish symbols made lighter #2761

merged 1 commit into from
Aug 22, 2017

Conversation

kocio-pl
Copy link
Collaborator

@kocio-pl kocio-pl commented Aug 17, 2017

Follow up to #2714 (comment).

Mapnik seems to render SVG in its own way, which is beyond our control and sometimes makes details to vanish, as it is with our current star of David. We can however try a symbol with thinner lines.

I took star_of_david3.svg from jsdotpattern project. It's rather not pixel aligned, but general religion symbol looks now better, because holes are visible. Cemetery symbol (the same shape scaled down to 10x9 px) is still worse than PNG (no small holes inside), so I would probably not use it:

Before
ntu8hdz1
After
kj9hfe88

Before
hby7cmh7
After
mdlvrzew

@kocio-pl kocio-pl requested review from pnorman and nebulon42 August 17, 2017 20:00
@nebulon42
Copy link
Contributor

Looks not bad to me. Could link or post an image with the symbol before? Would make it easier for me to compare.
Cemetery is not very visible but recognizable. How does it look currently?

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 18, 2017

I have updated both images with before/after renderings.

I'm not sure now about cemetery. With new symbol the lightness is similar and while I can spot the holes with general symbol with normal size (100-120%), cemetery symbol holes are not visible at 100% - it needs a lot of zooming (for me it's >200%), which is not what typical user would do. So maybe cemetery symbol should be moved to SVG too.

@sommerluk
Copy link
Collaborator

The general jewish religion symbol „after“ looks much clearer to me than the „before“ version. It can be recognized as Star of David.

About the cemetery symbol: Honestly, both, the „before“ and the „after“ variant, I cannot reliably recognize them as Star of David. They are just to small. But the „after“ variant – even though stronger – seems to me easier to guess as Star of David.

👍

@kocio-pl kocio-pl changed the title Jewish symbols made lighter [WIP] Jewish symbols made lighter Aug 18, 2017
Copy link
Contributor

@nebulon42 nebulon42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to concur with @sommerluk.

@imagico
Copy link
Collaborator

imagico commented Aug 19, 2017

Although i would assume this is clear but just in case it is not - this demonstrates the incorrect but consistent case described in #2750.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 19, 2017

Sorry, I don't understand it - could you describe in short words what exactly is incorrect and what do you think is consistent with this case? Any ideas what should be done to make it OK for you?

@imagico
Copy link
Collaborator

imagico commented Aug 19, 2017

The results in your After example above are not a faithful rendition of the SVG file, you can easily see this by comparing these results with a rendering of the pattern with other programs (Inkscape or ImageMagick) or with Mapnik when using polygon-gamma: 1;.

Incorrect but consistent refers to what i wrote in #2750:

It affects patterns in landcover-area-symbols - if observations in kosmtik are representative patterns in the normal landcover layer will render incorrectly but consistently with polygon-gamma other than 1 and correctly otherwise (the latter being the current situation for the quarry pattern) polygon-pattern-gamma does not appear to have an effect on this.

I don't know a way to fix this - otherwise i would have mentioned this in #2750.

@kocio-pl
Copy link
Collaborator Author

It looks like people are in favour of this rendering not because it's rendered similar to a vector image, but because it works better (in a cartographic sense) than current PNG image for them - and for me too.

Solving the problem with Mapnik might give us the ultimate solution to this problem, but this PR would still make a progress with readability and fixes problem with map scaling, so it's worth merging IMO.

@kocio-pl kocio-pl merged commit dbc633a into gravitystorm:master Aug 22, 2017
@kocio-pl kocio-pl deleted the jewish branch August 22, 2017 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants