[WIP] Rewrite roads layers #2869

pnorman · 2017-09-26T03:56:29Z

Fixes #2046
Fixes #2468

This is a complete rewrite of the transportation code. The primary goals are

Go from 9 road layers to 2
Get all the MSS for each feature in the same place
Avoid selecting from planet_osm_line once for roads and once for railways
Reduce MSS duplication

Once I'm farther along I'll set up a demo, but there are still features not yet implemented.

The layer changes are to move barrier-like features, landuse overlays, and ferry-routes before roads, and to move aerialways and waterway-bridges after roads.

Cartographic changes

Non-motorized paths (footway/path, cycleway, and bridleway) use the footway width
Various minor adjustments of start zooms for casings, bridges, etc to be consistent.

Remaining work

Long-term I'd like to redo names, but intend to keep that out of this PR

Known issues

Footway weight has changed.

I'm not sure what has caused this, but unknown surface footways are lighter.

For testing, areas likely to have problems will involve

Endcaps
Complex layering

This sets the framework in place

sommerluk · 2017-09-26T09:08:57Z

transportation.mss

+      }
+    }
+  }
+  [highway = 'pedestrian'],


Missing newline above this line

sommerluk · 2017-09-26T09:11:47Z

project.mml

+              AND points.highway IN ('turning_circle', 'turning_loop')
+              AND lines.highway IN ('tertiary', 'unclassified', 'residential', 'living_street', 'service', 'track')
+              ORDER BY points.osm_id, -- for DISTINCT ON
+                CASE lines.highway -- Use the most important type for cases where the TC is at an intersection. TODO: Should lines.layer be in here?


Is it possible to simply use z_order instead of this multiline-CASE?

sommerluk · 2017-09-26T09:16:12Z

project.mml

+              COALESCE(bridge IN ('yes', 'boardwalk', 'cantilever', 'covered', 'low_water_crossing', 'movable', 'trestle', 'viaduct'), FALSE) AS bridge,
+              COALESCE(layer,0) AS layernotnull,
+              z_order,
+              surface IN ('paved', 'asphalt', 'cobblestone', 'cobblestone:flattened', 'sett', 'concrete', 'concrete:lanes', 'concrete:plates', 'paving_stones', 'metal', 'wood')


Doesn’t this query always return TRUE for everything that is not in the “unpaved” list anyway, making the query for th e“paved” list obsolete?

No, but there is a bug with values not in either list.

pnorman · 2017-09-29T06:24:25Z

Noting a minor bug

Pedestrian features are rendering above turning circles fill

sommerluk · 2017-10-12T17:36:09Z

Currently, first comes the code for more important features with high z_order (e.g. highway=motorway) and later the code for less important features with low z_order (e.g. highway=track).

Might it be an option to use the opposite order?

This would not make any functional change.

For the code proposed in #2640 (unpaved roads with dst-out pattern), the opposite order would make it a lot easier. In fact, the diff of #2640 is difficult to read because it needs the opposite order because it uses attachments. The code changes themself are not so heavy.

And maybe this is also useful independent from #2640. Indeed the old road code has high z_order features first. But the attachment concept in MSS works the other way around: First attachment drawn first, last attachment drawn last (above the other ones). As we use attachments anyway in our roads MSS code, it could be more intuitive to have the rest following the same logic…

pnorman · 2017-10-13T05:15:46Z

Currently, first comes the code for more important features with high z_order (e.g. highway=motorway) and later the code for less important features with low z_order (e.g. highway=track).

Might it be an option to use the opposite order?

I find it easier to read from most important to least important.

For the code proposed in #2640 (unpaved roads with dst-out pattern), the opposite order would make it a lot easier. In fact, the diff of #2640 is difficult to read because it needs the opposite order because it uses attachments. The code changes themself are not so heavy.

I'd rather keep it as-is for now, then we can look at changing it if necessary.

As we use attachments anyway in our roads MSS code, it could be more intuitive to have the rest following the same logic…

Generally we order in descending significance for MSS.

It's interesting to note that within the SQL, the order by statements are both ascending and descending, depending on if its drawing lines and fills, or placing labels.

sommerluk · 2017-10-13T14:14:37Z

It's interesting to note that within the SQL, the order by statements are both ascending and descending, depending on if its drawing lines and fills, or placing labels.

Good point.

sommerluk · 2017-11-03T11:29:01Z

Will the road layer rewrite resolve at the same time #2595 (construction roads should not be wider than their finished counterparts)?

pnorman · 2017-11-04T17:10:06Z

Will the road layer rewrite resolve at the same time #2595 (construction roads should not be wider than their finished counterparts)?

I'm not intending to make cartographic changes, but that one will depend on how the construction MSS is structured.

kocio-pl · 2018-01-16T20:16:52Z

@pnorman What is the current state of this code? Do you still plan to update it to be mergable (maybe just some part of it, if the task is too big)?

pnorman · 2018-02-21T22:33:11Z

@pnorman What is the current state of this code?

I've been lacking time and interest.

Do you still plan to update it to be mergable (maybe just some part of it, if the task is too big)?

I don't really see a way to split it down in scope.

The best way to help this out would be for someone to pair up with me and we could work on it together. This would also be a good chance for someone to learn more about complex CartoCSS. The new roads code is simpler, but roads are still one of our biggest areas.

kocio-pl · 2018-02-22T22:00:30Z

Thanks for the information. Is there anybody wanting to help Paul with this code?

matthijsmelissen · 2018-05-07T19:54:16Z

I'm closing this as currently nobody is interested in working on this.

If anybody is interested, feel free to create a new proposal.

@pnorman Thanks a lot for the work you put in so far! Hopefully somebody else can pick up.

pnorman added 13 commits September 18, 2017 17:22

Start rewrite of roads with motorized roads z10+

ae87bb6

This sets the framework in place

Remove old road layers

9548700

Use keyword for mapnik geometry type, not number

0efb06c

Add residential TCs and stop old TC rendering

433c8c0

Add raceways

6cd4b40

Remove lz road layer for now

3807be1

Add LZ styling

94a963f

Convert bridleways

6d87671

Add other dashed line path styles

71bbdcd

Add steps

d94513a

Add tracks

8eab84e

Add remainder of TCs

93830ac

Add rail, trams, and more highway areas

79eb4b4

pnorman added the roads label Sep 26, 2017

pnorman added 3 commits September 25, 2017 22:47

Add service areas

f9ff45d

Convert platforms

e21838a

Add minor service road areas and tram bridges

ee8ee16

sommerluk reviewed Sep 26, 2017

View reviewed changes

transportation.mss Outdated

}

}

}

[highway = 'pedestrian'],

Copy link

Collaborator

sommerluk Sep 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline above this line

sommerluk reviewed Sep 26, 2017

View reviewed changes

pnorman added 6 commits September 26, 2017 03:02

Fix surface logic

edc3d62

Add missing tram bridge line

eb4f104

platform indentation

aeae239

Add subways

5edf683

Whitespace fix

0e7159b

Use z_order instead of a case ordering statement

5666d25

pnorman added 3 commits September 29, 2017 00:11

Add preserved rail

33e6b75

Add light_rail and similar rail

0b713c8

Add monorails

4574c98

pnorman mentioned this pull request Sep 29, 2017

Unify railway rendering #2872

Open

sommerluk mentioned this pull request Oct 7, 2017

Render “surface” tag on roads with a pattern #2640

Merged

pnorman added 4 commits October 8, 2017 02:04

Convert disused railways

1ab289a

Fix disused whitespace

7979f9b

Convert miniature railways

d5cffce

Fix steps bridge width

48b7bf8

Repository owner deleted a comment from sommerluk Oct 12, 2017

pnorman mentioned this pull request Dec 4, 2017

Slow carto layers #1941

Open

kocio-pl mentioned this pull request Mar 31, 2018

Add rendering for waterway=waterfall #336

Closed

kocio-pl mentioned this pull request Apr 28, 2018

Guidelines for adding new features #1630

Open

matthijsmelissen closed this May 7, 2018

matthijsmelissen deleted the roads_rewrite/master branch May 8, 2018 22:33

pitdicker mentioned this pull request Sep 9, 2021

Reorder layers to get all the road layers together #4464

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Rewrite roads layers #2869

[WIP] Rewrite roads layers #2869

pnorman commented Sep 26, 2017 •

edited

Loading

sommerluk Sep 26, 2017

sommerluk Sep 26, 2017

sommerluk Sep 26, 2017

pnorman Sep 26, 2017

pnorman commented Sep 29, 2017

sommerluk commented Oct 12, 2017

pnorman commented Oct 13, 2017

sommerluk commented Oct 13, 2017

sommerluk commented Nov 3, 2017

pnorman commented Nov 4, 2017

kocio-pl commented Jan 16, 2018 •

edited

Loading

pnorman commented Feb 21, 2018

kocio-pl commented Feb 22, 2018

matthijsmelissen commented May 7, 2018

[WIP] Rewrite roads layers #2869

[WIP] Rewrite roads layers #2869

Conversation

pnorman commented Sep 26, 2017 • edited Loading

Cartographic changes

Remaining work

Known issues

sommerluk Sep 26, 2017

Choose a reason for hiding this comment

sommerluk Sep 26, 2017

Choose a reason for hiding this comment

sommerluk Sep 26, 2017

Choose a reason for hiding this comment

pnorman Sep 26, 2017

Choose a reason for hiding this comment

pnorman commented Sep 29, 2017

sommerluk commented Oct 12, 2017

pnorman commented Oct 13, 2017

sommerluk commented Oct 13, 2017

sommerluk commented Nov 3, 2017

pnorman commented Nov 4, 2017

kocio-pl commented Jan 16, 2018 • edited Loading

pnorman commented Feb 21, 2018

kocio-pl commented Feb 22, 2018

matthijsmelissen commented May 7, 2018

pnorman commented Sep 26, 2017 •

edited

Loading

kocio-pl commented Jan 16, 2018 •

edited

Loading