Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move natural=spring back to amenity-points layer #4069

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

jeisenbe
Copy link
Collaborator

Fixes #4011

Changes proposed in this pull request:

  • Move natural=spring icon back to amenity-points layer, delete current springs layer
  • Previously springs were rendered below water-lines. This is not longer the case, so springs can be rendered with other symbols again
  • Springs now render above paths and highways, like other point symbols.
  • This change should slightly improve performance, and springs will no longer render with priority to placenames such as hamlets and villages.

Test rendering with links to the example places:

z14 Before
z14-japan-springs-before png

z14 After - place label now seen (upper left)
z14-japan-springs-after

z15 before
z15-japan-springs-before png

z15 after
z15-japan-springs-after

z16 before
z16-japan-springs-before-

z16 after
z16-japan-springs-after

  • Shinto place of worship, place name, and funicular station now all show with priority over the springs.

Previously springs were rendered below water-lines. This is not longer the case, so springs can be rendered with other symbols again
@imagico
Copy link
Collaborator

imagico commented Mar 12, 2020

Note this symbol for springs was never intended to be used as a POI style icon.

I would probably rather prefer to see a full revert of #3189 for the reasons explained in #325 (comment) but there is likely no consensus for that.

@jeisenbe
Copy link
Collaborator Author

I am in favor of changing the spring icon. I think @kocio-pl also thinks it is too large at low zoom level. We discussed this previously but did not reach consensus in #3461

I would support using a much smaller, abstract icon at low zoom levels and a slightly smaller icon at high zoom levels.

But this PR will be an improvement, since springs are currently blocking placenames that appear sooner.

@jeisenbe
Copy link
Collaborator Author

I also would like to see geysers and hot springs rendered: #3461 (comment) - also see test images in #3461 (comment)

Copy link
Collaborator

@pnorman pnorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also in favour of changing the spring icon, but this helps with the priority issues and doesn't make the icon situation worse.

@pnorman pnorman merged commit 8c18ef8 into gravitystorm:master Mar 27, 2020
@jeisenbe jeisenbe deleted the springs-layer branch March 27, 2020 02:30
jeisenbe added a commit to jeisenbe/openstreetmap-carto that referenced this pull request Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

natural=spring blocks place node labels
3 participants