-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add amenity=research_institute #4278
Conversation
Technically the change seems to be fine (though i have not tested it) - but note the remarks made in #2077 (comment). |
Yes, all comments about But I don't know how to deploy a render server on my own computer so I can't give a AFTER version. So I want this PR can be judge by more active-contributors. Thank you for your review! |
I'm in favour of that rendering which is overdue now. |
style/amenity-points.mss
Outdated
@@ -2286,6 +2287,9 @@ | |||
[feature = 'amenity_college'], | |||
[feature = 'amenity_university'] { | |||
text-fill: darken(@societal_amenities, 80%); | |||
} | |||
[feature = 'amenity_research_institute'] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can merge this entry with the block of kindergarten, school, college and university.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emmm……but kindergarten or school are separated, so I think institute should be like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
I‘m new in this repo.
I guess your expected code is like that?
[feature = 'amenity_kindergarten'],
[feature = 'amenity_school'],
[feature = 'amenity_college'],
[feature = 'amenity_university' || feature = 'amenity_research_institute'] {
text-fill: darken(@societal_amenities, 80%);
}
(I don't know whether those is Grammatical (T_T))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess your expected code is like that?
No:
[feature = 'amenity_school'],
[feature = 'amenity_college'],
[feature = 'amenity_university'],
[feature = 'amenity_research_institute'] {
Cartocss is based on CSS syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edited.Thanks @HolgerJeromin
@LaoshuBaby thank you for this PR. As @HolgerJeromin has mentioned, there is a small technical change that needs to be made in the code to make it a bit shorter. It is also important to review the changes yourself by rendering the map. While this can be done by the maintainers, we would like contributors to check how the change will look on the map of their own area and some other example locations. This can bring out problems with the current use of the tag, as mentioned in this commont: #2077 (comment) We need to make sure this tag is being used in a consistent way. If you don’t know how to set up the rendering server, there are detailed step-by-step instructions for doing this with Docker at this comment: #2291 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move line 2291 up 3 lines, between amenity_school and amenity_college
For those 2 comments: Yes, as @jeisenbe said. Maybe someone will render according to those commit out of sympathy. But before asking others for help, I think I should try it myself first. I had tried to configure the rendering server myself before but failed. This time I will do as #2291 like. |
[feature = 'amenity_kindergarten'], | ||
[feature = 'amenity_college'], | ||
[feature = 'amenity_research_institute'], | ||
[feature = 'amenity_university'] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You changed the order of the lines (kindergarten, school are swapped and the new entry is between collage and university). They are now different from the list above. Best to stay in one order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LaoshuBaby could you address the comment above?
@LaoshuBaby have you been able to test the rendering of this PR? |
Unfortunately, based on my research of how this tag is currently used - in #2077 (comment) - I am not convinced that this tag is being used in a consistent way, or that it would make sense to render the area the same as schools and universities. |
Good luck Next time will work on https://wiki.openstreetmap.org/wiki/Tag:tourism%3Dhotel |
Strange procedure @jeisenbe. |
The number of applications is now over 3500. Please open the proposal so that it can be implemented soon. |
Fixes:
Fixes [#2077 ]
Fixes [#4277 ](Duplicate of #2077 )
Changes proposed in this pull request:
Before
Reason
amenity=research_institute be rendered like amenity=university has been calling for a long time, and many contributor in that issue think about it.
It is the first time I PR to a so large repo so if there are something mistake, please comment to me! Please! Thanks!