Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

police etc landuses #771

Closed
wants to merge 1 commit into from

Conversation

polarbearing
Copy link
Contributor

This provides rendering for areas of amenity={police|prison} and landuse=religious, and closes

https://trac.openstreetmap.org/ticket/5197
https://trac.openstreetmap.org/ticket/3622
https://trac.openstreetmap.org/ticket/2512

Prison was apparently implemented in xml and did not make it to carto. The others are new.

The design for police adopts the diagonal hatching style we have for military areas/barracks, just in a neutral grey that blends with residential landuse. Prison does vertical hatching, as in the original implementation. Both icons are powers of two and allow global alignment. Landuse religious darkens residential colour by 8% and is in saturation between this and a place_of_worship.
po
pr
rl

@pnorman
Copy link
Collaborator

pnorman commented Jul 28, 2014

We have 1.6k uses of landuse=religious. That seems a bit small

@matkoniecz
Copy link
Contributor

Personally I like landuse=religious but there is ongoing discussion on @tagging.

Also, I think that wiki documentation should be improved - see http://wiki.openstreetmap.org/wiki/Talk:Tag:landuse%3Dreligious

But over 1k uses is IMHO not a problem.

@matthijsmelissen
Copy link
Collaborator

Closed for now awaiting the outcome of the discussion on tagging.

@polarbearing
Copy link
Contributor Author

Should I separate the two amenities from the landuse? It was just practical since they affect the same SQL query.

@matthijsmelissen
Copy link
Collaborator

If you could do that, that would be great, yes. Let me know when you have made the update, so I can reopen the PR.

@Rovastar
Copy link
Contributor

I thought I replied to this.
I don't like the hashing of the prison. Generally I dislike this type of hashing as the thin lines could look like some type of way and frankly look ugly.
I personally would prefer a solid colour.

@matkoniecz
Copy link
Contributor

For prison it works but I am unsure about police, currently it is used for rather inaccessible areas (prison would be the next one).

@polarbearing
Copy link
Contributor Author

Well the discussion on @tagging was mostly in favour of landuse=religion and then drifting into the usual dispute that our tagging scheme has historic inconsistencies in general. The tag has been used for years and is gaining interest since it has recently been translated from Polish into English, German and Japanese.

As for police, I understand that people see it less restrictive than military (though often civil visitors, similarly, get into a reception area only). So if we go for a single colour, which should it be? Amenity-yellow, like hospitals and schools? (talking about amenities, nursing_home and social_facility are not rendered...). That would be a rather quick fix.

Prison has been split off into #772.

@polarbearing
Copy link
Contributor Author

@mkoniecz - I have refined the wiki page according to your comments there, the discussion here and in @tagging; for the English and the German page. Are you able to do the Polish?

@matkoniecz
Copy link
Contributor

@polarbearing I will reply on wiki, I have this page on watchlist so it should not be necessary to notify me through github.

@dieterdreist
Copy link

Am 28/lug/2014 um 17:46 schrieb polarbearing notifications@github.com:

Well the discussion on @tagging was mostly in favour of landuse=religion

I had the opposite impression: it was said by several people that the religion tag was an established possibility to tag religious affiliation and that there would be overlap with other landuses for the examples discussed (residential and sports grounds), and that amenity=place_of_worship can be mapped on sacred areas that extend the building.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants