Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dgeni): render headings with slugified IDs #2927

Merged

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #2857

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

the slugify import is unfortunate but we need to ensure that we generate the same ID as the toc link

@griest024 griest024 added the tools: dgeni @daffodil/tools-dgeni label Jul 22, 2024
@griest024 griest024 self-assigned this Jul 22, 2024
@griest024 griest024 requested a review from a team as a code owner July 22, 2024 14:43
@griest024 griest024 added the status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin label Jul 22, 2024
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit e6d1b35 into graycoreio:develop Jul 22, 2024
10 checks passed
@gray-bot gray-bot mentioned this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin tools: dgeni @daffodil/tools-dgeni
Projects
None yet
2 participants