Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup code base #3

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Cleanup code base #3

merged 1 commit into from
Jan 2, 2024

Conversation

bernd
Copy link

@bernd bernd commented Nov 8, 2023

  • Remove unused Siddhi modules
    • modules/siddhi-service
    • modules/siddhi-samples
    • modules/siddhi-doc-gen
    • modules/siddhi-core/siddhi-core-doc-gen
    • coverage-reports
  • Remove commented code from pom.xml
  • Remove unused codestyle configuration
  • Remove unused maven plugins

@bernd bernd marked this pull request as ready for review November 14, 2023 09:46
@bernd bernd requested a review from mpfz0r November 14, 2023 09:47
mpfz0r
mpfz0r approved these changes Dec 27, 2023
View reviewed changes
Copy link

@mpfz0r mpfz0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully and LGTM 👍

@bernd bernd merged commit b9d5574 into graylog-repackaging Jan 2, 2024
2 checks passed
@bernd bernd deleted the cleanup branch January 2, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpfz0r mpfz0r mpfz0r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernd @mpfz0r