[FEATURE] Add include_rendered_content to get_expectation_suite and get_validation_result
#5853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f InlineRenderer public methods
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👇 Click on the image for a new way to code review
Legend |
… always needing to be contained in a Suite
…' of github.com:great-expectations/great_expectations into feature/GREAT-911/include_rendered_content_on_store_get
…correct include_rendered_content
…' of github.com:great-expectations/great_expectations into feature/GREAT-911/include_rendered_content_on_store_get
NathanFarmer
changed the title
include_rendered_content to get_expectation_suite and get_validation_resultinclude_rendered_content to get_expectation_suite and get_validation_result
Kilo59
reviewed
Aug 30, 2022
Kilo59
reviewed
Aug 30, 2022
added 2 commits
August 30, 2022 09:44
…' of github.com:great-expectations/great_expectations into feature/GREAT-911/include_rendered_content_on_store_get
Kilo59
approved these changes
Aug 30, 2022
| "render_object": self, | ||
| } | ||
| module_name = "great_expectations.render.renderer.inline_renderer" | ||
| inline_renderer = instantiate_class_from_config( |
There was a problem hiding this comment.
Could we just instantiate from the constructor e.g. inline_renderer = InlineRenderer(render_object=self)? Or is this a point of extensibility where we would accept a config?
There was a problem hiding this comment.
This is the issue with circular imports that we spent a lot of time trying to solve about a month ago and landed on this as a solution for now.
There was a problem hiding this comment.
Would you mind adding a small comment here in the code with that explanation? That way if we fix the circular import issue in the future we will have a hint that we can safely remove the instantiate_class_from_config() call
NathanFarmer
deleted the
feature/GREAT-911/include_rendered_content_on_store_get
branch
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Aug 31, 2022
…ssed-in-as-batchspec-passthrough-spark * develop: [MAINTENANCE] increase the `pytest-timeout` timeout value during unit-testing step (#5884) [BUGFIX] JSON Serialize RowCondition and MetricBundle computation result to enable IDDict.to_id() for SparkDFExecutionEngine (#5883) [MAINTENANCE] new invoke test flags (#5880) [MAINTENANCE] Label tests in `tests/core` with `@pytest.mark.unit` and `@pytest.mark.integration` (#5879) [MAINTENANCE] add `pytest-timeout` (#5857) [BUGFIX] Ensure that `delete_expectation_suite` returns proper boolean result (#5878) [FEATURE] Add `include_rendered_content` to `get_expectation_suite` and `get_validation_result` (#5853) [MAINTENANCE] run unit-tests on a target package (#5869) Update the 'Show DataFrame to SQL times' step of expectation_gallery pipeline to not die if no SQL backend used (#5874) don't force using the stand alone mock (#5871) [MAINTENANCE] Remove vendored `marshmallow__shade` (#5866) [MAINTENANCE] Misc cleanup of `test_expectation_suite_crud.py` (#5868) [MAINTENANCE] Handle Pandas warnings in Data Assistant plots (#5863) [MAINTENANCE] Update `ExpectationSuite` CRUD on `DataContext` to recognize Cloud ids (#5836)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
include_rendered_contenttocontext.get_expectation_suiteinclude_rendered_contenttocontext.get_validation_resultExpectationConfigurationnot contained in anExpectationSuiteCheckpointusingDataContextvariablesInlineRenderer.get_rendered_contentmethods now thatExpectationSuites will always be saved or retrieved withrendered_contentDefinition of Done