Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_interface/get_interface #38

Closed
wants to merge 1 commit into from

Conversation

gdsports
Copy link

@gdsports gdsports commented Mar 1, 2020

Linux USB printer driver always sends set_interface even when there is only one and no alternate.

0x01,       // bmRequestType: Dir: H2D, Type: Standard, Recipient: Interface
0x0B,       // bRequest (Set Interface)
0x00, 0x00, // wValue Alt Setting: 0
0x00, 0x00, // wIndex Interface: 0
0x00, 0x00, // wLength = 0

Linux USB printer driver always sends set_interface even when there is
only one and no alternate

0x01,       // bmRequestType: Dir: H2D, Type: Standard, Recipient: Interface
0x0B,       // bRequest (Set Interface)
0x00, 0x00, // wValue Alt Setting: 0
0x00, 0x00, // wIndex Interface: 0
0x00, 0x00, // wLength = 0
@straithe straithe added the enhancement potential new feature label Nov 1, 2021
@straithe straithe requested a review from mossmann November 12, 2021 18:37
@grvvy
Copy link
Member

grvvy commented Aug 4, 2022

Sorry for the delay @gdsports. This looks good, but I'm curious if you have a test case for something this fix applies to?

@antoinevg antoinevg requested review from antoinevg and removed request for mossmann January 3, 2023 07:54
@antoinevg antoinevg mentioned this pull request Jan 4, 2024
@antoinevg
Copy link
Member

USBInterface has been deprecated in favor of the new Facedancer future API which supports set/get-interface.

@antoinevg antoinevg closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement potential new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants