Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EC66] deprecation of EC66 rule for Python #9

Merged
merged 2 commits into from
Dec 15, 2023
Merged

[EC66] deprecation of EC66 rule for Python #9

merged 2 commits into from
Dec 15, 2023

Conversation

dedece35
Copy link
Member

@dedece35 dedece35 commented Dec 11, 2023 •
edited
Loading

deprecation of EC66 for Python becasue finally not applicable for Python.

check discussion on issue #4

other related PR in ecocode repository : green-code-initiative/ecoCode#261

@dedece35 dedece35 added the 🗃️ rule rule improvment or rule development or bug label Dec 11, 2023
@dedece35 dedece35 self-assigned this Dec 11, 2023
@dedece35 dedece35 linked an issue Dec 11, 2023 that may be closed by this pull request
Rule EC66 does not apply to the Python language #4
Closed
@dedece35 dedece35 mentioned this pull request Dec 11, 2023
Merged
@dedece35 dedece35 mentioned this pull request Dec 11, 2023
Closed
@dedece35
Copy link
Member Author

Hi @jycr
the PR green-code-initiative/ecoCode#261 has just been merged in ecoCode repository.
could you create a new release of ecocode-rules-specifications to reference it in this python PR ?
thank you, in advance.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 15, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@dedece35 dedece35 merged commit d813f4e into main Dec 15, 2023
1 of 2 checks passed
@dedece35 dedece35 deleted the ISSUE_4 branch December 15, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utarwyn utarwyn Awaiting requested review from utarwyn

@jhertout jhertout Awaiting requested review from jhertout

Assignees

@dedece35 dedece35

Labels
🗃️ rule rule improvment or rule development or bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule EC66 does not apply to the Python language
1 participant
@dedece35