[ISSUE 161] ➖ Remove unused junit dependency

green-code-initiative · Apr 14, 2023 · 56a4498 · 56a4498
1 parent 4d99545
commit 56a4498
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 44 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - [171](https://github.com/green-code-initiative/ecoCode/issues/171) Add migration mechanism to support "issue re-keying"
 
 ### Changed
+- [#161](https://github.com/green-code-initiative/ecoCode/pull/161) Remove unnecessary junit dependencies in pom.xml
 
 - [166](https://github.com/green-code-initiative/ecoCode/issues/166) Correction of wrong message of rule EC63
 - [167](https://github.com/green-code-initiative/ecoCode/issues/167) Use same kind for rules across different languages

diff --git a/java-plugin/pom.xml b/java-plugin/pom.xml
@@ -69,12 +69,6 @@
             <scope>test</scope>
         </dependency>
 
-        <dependency>
-            <groupId>org.junit.jupiter</groupId>
-            <artifactId>junit-jupiter-migrationsupport</artifactId>
-            <scope>test</scope>
-        </dependency>
-
         <dependency>
             <groupId>org.assertj</groupId>
             <artifactId>assertj-core</artifactId>

diff --git a/javascript-plugin/pom.xml b/javascript-plugin/pom.xml
@@ -38,11 +38,9 @@
             <artifactId>sonar-analyzer-commons</artifactId>
         </dependency>
 
-        <!-- Testing dependencies -->
-
         <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter</artifactId>
             <scope>test</scope>
         </dependency>
 

diff --git a/javascript-plugin/src/test/java/fr/greencodeinitiative/javascript/JavaScriptPluginTest.java b/javascript-plugin/src/test/java/fr/greencodeinitiative/javascript/JavaScriptPluginTest.java
@@ -1,15 +1,15 @@
 package fr.greencodeinitiative.javascript;
 
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 import org.sonar.api.*;
 import org.sonar.api.utils.Version;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class JavaScriptPluginTest {
+class JavaScriptPluginTest {
 
     @Test
-    public void extensions() {
+    void extensions() {
         Plugin.Context context = new Plugin.Context(new MockedSonarRuntime());
         new JavaScriptPlugin().define(context);
         assertThat(context.getExtensions()).hasSize(1);

diff --git a/...plugin/src/test/java/fr/greencodeinitiative/javascript/JavaScriptRulesDefinitionTest.java b/...plugin/src/test/java/fr/greencodeinitiative/javascript/JavaScriptRulesDefinitionTest.java
@@ -1,14 +1,14 @@
 package fr.greencodeinitiative.javascript;
 
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 import org.sonar.api.server.rule.RulesDefinition;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class JavaScriptRulesDefinitionTest {
+class JavaScriptRulesDefinitionTest {
 
     @Test
-    public void createExternalRepository() {
+    void createExternalRepository() {
         RulesDefinition.Context context = new RulesDefinition.Context();
         new JavaScriptRulesDefinition().define(context);
         assertThat(context.repositories()).hasSize(1);

diff --git a/php-plugin/pom.xml b/php-plugin/pom.xml
@@ -40,18 +40,11 @@
 <!--            <artifactId>re2j</artifactId>-->
 <!--        </dependency>-->
 
-        <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <scope>test</scope>
-        </dependency>
-
         <dependency>
             <groupId>org.assertj</groupId>
             <artifactId>assertj-core</artifactId>
             <scope>test</scope>
         </dependency>
-
     </dependencies>
 
     <build>

diff --git a/pom.xml b/pom.xml
@@ -67,7 +67,6 @@
         <sonar-packaging.version>1.21.0.505</sonar-packaging.version>
         <sonar.skipDependenciesPackaging>true</sonar.skipDependenciesPackaging>
         <maven-shade-plugin.version>3.4.1</maven-shade-plugin.version>
-        <junit.version>4.13.2</junit.version>
         <junit.jupiter.version>5.9.1</junit.jupiter.version>
         <assertJ.version>3.23.1</assertJ.version>
 
@@ -156,27 +155,13 @@
                 <scope>test</scope>
             </dependency>
 
-            <dependency>
-                <groupId>org.junit.jupiter</groupId>
-                <artifactId>junit-jupiter-migrationsupport</artifactId>
-                <version>${junit.jupiter.version}</version>
-                <scope>test</scope>
-            </dependency>
-
             <dependency>
                 <groupId>org.assertj</groupId>
                 <artifactId>assertj-core</artifactId>
                 <version>${assertJ.version}</version>
                 <scope>test</scope>
             </dependency>
 
-            <dependency>
-                <groupId>junit</groupId>
-                <artifactId>junit</artifactId>
-                <version>${junit.version}</version>
-                <scope>test</scope>
-            </dependency>
-
             <dependency>
                 <groupId>org.sonarsource.python</groupId>
                 <artifactId>python-checks-testkit</artifactId>

diff --git a/python-plugin/pom.xml b/python-plugin/pom.xml
@@ -44,12 +44,6 @@
             <scope>test</scope>
         </dependency>
 
-        <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <scope>test</scope>
-        </dependency>
-
     </dependencies>
 
     <build>