Skip to content

Commit

Permalink
Merge pull request #218 from green-code-initiative/ISSUE_182_php
Browse files Browse the repository at this point in the history
[ISSUE 182] PHP - remove PHP module because of moving to new repository
  • Loading branch information
dedece35 authored Aug 8, 2023
2 parents 25c62ac + 3d3a959 commit bdcc5bf
Show file tree
Hide file tree
Showing 45 changed files with 6 additions and 2,439 deletions.
21 changes: 0 additions & 21 deletions .github/workflows/manual_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,24 +89,3 @@ jobs:
asset_path: lib/ecocode-java-plugin-${{ needs.build.outputs.last_tag }}.jar
asset_name: ecocode-java-plugin-${{ needs.build.outputs.last_tag }}.jar
asset_content_type: application/zip
upload-php:
name: Upload PHP Plugin
runs-on: ubuntu-latest
needs: build
steps:
- name: Import plugin JAR files
id: import_jar_files
uses: actions/download-artifact@v3
with:
name: ecocode-plugins
path: lib
- name: Upload Release Asset - PHP Plugin
id: upload-release-asset
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{needs.build.outputs.upload_url}}
asset_path: lib/ecocode-php-plugin-${{ needs.build.outputs.last_tag }}.jar
asset_name: ecocode-php-plugin-${{ needs.build.outputs.last_tag }}.jar
asset_content_type: application/zip
21 changes: 0 additions & 21 deletions .github/workflows/tag_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,24 +69,3 @@ jobs:
asset_path: lib/ecocode-java-plugin-${{ github.ref_name }}.jar
asset_name: ecocode-java-plugin-${{ github.ref_name }}.jar
asset_content_type: application/zip
upload-php:
name: Upload PHP Plugin
runs-on: ubuntu-latest
needs: build
steps:
- name: Import plugin JAR files
id: import_jar_files
uses: actions/download-artifact@v3
with:
name: ecocode-plugins
path: lib
- name: Upload Release Asset - PHP Plugin
id: upload-release-asset
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{needs.build.outputs.upload_url}}
asset_path: lib/ecocode-php-plugin-${{ github.ref_name }}.jar
asset_name: ecocode-php-plugin-${{ github.ref_name }}.jar
asset_content_type: application/zip
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Deleted

- [#182](https://github.com/green-code-initiative/ecoCode/issues/182) Split repository : move Python module to new `ecoCode-python` repository
- [#182](https://github.com/green-code-initiative/ecoCode/issues/182) Split repository : move Php module to new `ecoCode-php` repository

## [1.3.1] - 2023-07-19

Expand Down
3 changes: 0 additions & 3 deletions INSTALL.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ ecoCode # Root directory
|
+--java-plugin # JAVA
|
+--php-plugin # PHP
|
\--docker-compose.yml # Docker compose file
```

Expand All @@ -32,4 +30,3 @@ You will find more information about the plugins’ architecture in their folder
### Plugin-specific guides

- [Java how-to](java-plugin/README.md)
- [PHP how-to](php-plugin/README.md)
2 changes: 0 additions & 2 deletions TODOs_DDC.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ actions vues perso :
- nettoyer le MIGRATION_TODOs.md
- ménage dans les branches de dev (local et remote)
- JYC : suppression dépendance analyser-commons ==> check si bien tout nettoyé (version dans pom, référence dans code)
- créer issue sur la rule EC2 (`avoidMultipleIfElse`) sur JAVA :
- JAVA : existe depuis longtemps !!! normal que l'implem PHP et python aient le même code minimaliste fonctionellement
- voir les rules désativées chez PJ, créer des issues et corriger (`avoidMultipleIfElse`) :
- voir pourquoi désactivées car ralaient trop
- retester le EC2
7 changes: 2 additions & 5 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,8 @@ services:
SONAR_ES_BOOTSTRAP_CHECKS_DISABLE: 'true'
volumes:
- type: bind
source: ./java-plugin/target/ecocode-java-plugin-1.3.2-SNAPSHOT.jar
target: /opt/sonarqube/extensions/plugins/ecocode-java-plugin-1.3.2-SNAPSHOT.jar
- type: bind
source: ./php-plugin/target/ecocode-php-plugin-1.3.2-SNAPSHOT.jar
target: /opt/sonarqube/extensions/plugins/ecocode-php-plugin-1.3.2-SNAPSHOT.jar
source: ./java-plugin/target/ecocode-java-plugin-1.4.0-SNAPSHOT.jar
target: /opt/sonarqube/extensions/plugins/ecocode-java-plugin-1.4.0-SNAPSHOT.jar
- "extensions:/opt/sonarqube/extensions"
- "logs:/opt/sonarqube/logs"
- "data:/opt/sonarqube/data"
Expand Down
2 changes: 1 addition & 1 deletion ecocode-rules-specifications/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<groupId>io.ecocode</groupId>
<artifactId>ecocode-parent</artifactId>
<version>1.3.2-SNAPSHOT</version>
<version>1.4.0-SNAPSHOT</version>
</parent>

<artifactId>ecocode-rules-specifications</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion java-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<groupId>io.ecocode</groupId>
<artifactId>ecocode-parent</artifactId>
<version>1.3.2-SNAPSHOT</version>
<version>1.4.0-SNAPSHOT</version>
</parent>

<artifactId>ecocode-java-plugin</artifactId>
Expand Down
1 change: 0 additions & 1 deletion php-plugin/README.md

This file was deleted.

143 changes: 0 additions & 143 deletions php-plugin/pom.xml

This file was deleted.

28 changes: 0 additions & 28 deletions php-plugin/src/main/java/fr/greencodeinitiative/php/PHPPlugin.java

This file was deleted.

This file was deleted.

Loading

0 comments on commit bdcc5bf

Please sign in to comment.