Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP plugin] duplicate rules definition class #85

Closed
dedece35 opened this issue Mar 26, 2023 · 1 comment
Closed

[PHP plugin] duplicate rules definition class #85

dedece35 opened this issue Mar 26, 2023 · 1 comment
Assignees
@dedece35
Labels
🔰 good first issue Good for newcomers php __PRIO_HIGH__ 💉 bug Something isn't working

Comments

@dedece35
Copy link
Member

dedece35 commented Mar 26, 2023 •
edited
Loading

there are two files to declare rules definition on PHP plugin : PhpRuleRepository and PhpRulesDefinition.
But, actually, PhpRuleRepository is really used in PHPPlugin.
But there is a unit test for PhpRulesDefinition and no unit test for PhpRuleRepository.

After PR #79 merged, correct this pb of duplicated classes and unit tests.
@dedece35 dedece35 added the 💉 bug Something isn't working label Mar 26, 2023
@dedece35 dedece35 self-assigned this Mar 26, 2023
@dedece35 dedece35 mentioned this issue Mar 26, 2023
Merged
@dedece35
Copy link
Member Author

done with PR #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dedece35 dedece35

Labels
🔰 good first issue Good for newcomers php __PRIO_HIGH__ 💉 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dedece35