Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issues raised for adding plugin to SonarQube marketplace #79

Merged
merged 8 commits into from
Mar 29, 2023
Merged

Fixes issues raised for adding plugin to SonarQube marketplace #79

merged 8 commits into from
Mar 29, 2023

Conversation

jycr
Copy link
Contributor

@jycr jycr commented Mar 15, 2023 •
edited
Loading

@jycr jycr force-pushed the feature/63--add-ecoCode-plugin-to-sonarQube-marketplace branch 2 times, most recently from 8b6aa14 to 8b0dadd Compare March 16, 2023 01:21
@jycr jycr mentioned this pull request Mar 16, 2023
Closed
@jycr jycr force-pushed the feature/63--add-ecoCode-plugin-to-sonarQube-marketplace branch from a71d962 to 69cfad6 Compare March 17, 2023 01:12
@jycr jycr requested a review from utarwyn March 17, 2023 07:36
@dedece35
Copy link
Member

@jycr
please correct conflicts ...
but as i see, conflitcs are on JSON files I've just modified for other issues. sorry.

@jycr jycr force-pushed the feature/63--add-ecoCode-plugin-to-sonarQube-marketplace branch from 69cfad6 to 612b9eb Compare March 21, 2023 17:26
@jycr jycr mentioned this pull request Mar 21, 2023
Closed
@jycr
Copy link
Contributor Author

jycr commented Mar 21, 2023

@dedece35 : I've fixed conflicts

utarwyn
utarwyn reviewed Mar 21, 2023
View reviewed changes
java-plugin/pom.xml Outdated Show resolved Hide resolved
@jycr jycr force-pushed the feature/63--add-ecoCode-plugin-to-sonarQube-marketplace branch from f12ac02 to c889050 Compare March 22, 2023 17:28
@jycr jycr requested review from utarwyn and dedece35 and removed request for utarwyn and dedece35 March 22, 2023 18:49
@jycr jycr force-pushed the feature/63--add-ecoCode-plugin-to-sonarQube-marketplace branch 2 times, most recently from 85bf6d4 to 88edc7c Compare March 23, 2023 15:37
@jycr
Copy link
Contributor Author

jycr commented Mar 23, 2023

@dedece35 : do you need me to make any other corrections so that you can merge this branch?

@dedece35
Copy link
Member

Hi @jycr,
sorry I made several updates today ...
another conflicts to resolve, sorry.

I will review this week-end if possible.

First feedback : 143 files changed ! Wow :(
Maybe, next time, several PR would be more simple to review.

@jycr jycr force-pushed the feature/63--add-ecoCode-plugin-to-sonarQube-marketplace branch from 88edc7c to 615092d Compare March 26, 2023 01:12
@jycr
Copy link
Contributor Author

jycr commented Mar 26, 2023 •
edited
Loading

Hi @jycr, sorry I made several updates today ... another conflicts to resolve, sorry.

I will review this week-end if possible.

First feedback : 143 files changed ! Wow :( Maybe, next time, several PR would be more simple to review.

@dedece35 : I reworked my commits (strictly necessary to resolve @ganncamp's remarks) to minimize the number of differences.
Code review should be easier.

@dedece35 dedece35 mentioned this pull request Mar 26, 2023
Closed
dedece35
dedece35 requested changes Mar 26, 2023
View reviewed changes
Copy link
Member

@dedece35 dedece35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jycr,
review done, please make modifications and then I will approve your PR.

java-plugin/pom.xml Show resolved Hide resolved
java-plugin/src/main/java/fr/greencodeinitiative/java/JavaRulesDefinition.java Show resolved Hide resolved
python-plugin/src/main/java/fr/greencodeinitiative/python/PythonRuleRepository.java Outdated Show resolved Hide resolved
java-plugin/src/main/java/fr/greencodeinitiative/java/checks/ArrayCopyCheck.java Show resolved Hide resolved
php-plugin/src/main/java/fr/greencodeinitiative/php/PhpRulesDefinition.java Show resolved Hide resolved
php-plugin/src/main/java/fr/greencodeinitiative/php/checks/UseOfMethodsForBasicOperations.java Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@jycr
feat: improves the information displayed in the plugins administration
518d2ca
@jycr
green-code-initiative#63 - refactor: shortens rule repo names and tags
5c043ce 
see: https://community.sonarsource.com/t/new-plugin-ecocode-requesting-inclusion-in-sonarqube-marketplace/85398/4#optional-2
@jycr
green-code-initiative#63 - refactor: change rule key prefix to not co…
3872944 
…llide with SonarQube bundled rules (prefixed with 'S')

see:
° https://community.sonarsource.com/t/new-plugin-ecocode-requesting-inclusion-in-sonarqube-marketplace/85398/4#to-do-1
* https://community.sonarsource.com/t/new-plugin-ecocode-requesting-inclusion-in-sonarqube-marketplace/85398/10
@jycr
green-code-initiative#63 - doc: Add tags (e.g.: performance, memory, …
c258b35 
…network, sql, ...) where appropriate

see: https://community.sonarsource.com/t/new-plugin-ecocode-requesting-inclusion-in-sonarqube-marketplace/85398/4#optional-2
@jycr
green-code-initiative#63 - doc: Adds "Noncompliant" comment
c5724de 
See: https://community.sonarsource.com/t/new-plugin-ecocode-requesting-inclusion-in-sonarqube-marketplace/85398/4#optional-2
@jycr
green-code-initiative#63 - doc: Fixes misleading documentation
c2f7527 
See: https://community.sonarsource.com/t/new-plugin-ecocode-requesting-inclusion-in-sonarqube-marketplace/85398/4#optional-2
@jycr jycr force-pushed the feature/63--add-ecoCode-plugin-to-sonarQube-marketplace branch from 615092d to c2f7527 Compare March 27, 2023 07:39
@jycr jycr requested review from dedece35 and utarwyn and removed request for utarwyn and dedece35 March 27, 2023 08:30
@jycr
Copy link
Contributor Author

jycr commented Mar 27, 2023

@dedece35 : Do you know why there is always an error on Docker Build (from: Github build pipeline) ?

ERROR: failed to solve: failed to push ghcr.io/green-code-initiative/sonarqube-ecocode:pr-79: unexpected status: 403 Forbidden
Error: buildx failed with: ERROR: failed to solve: failed to push ghcr.io/green-code-initiative/sonarqube-ecocode:pr-79: unexpected status: 403 Forbidden

@utarwyn
Copy link
Member

utarwyn commented Mar 28, 2023

@jycr
Do you know why there is always an error on Docker Build (from: Github build pipeline) ?

Hello! The GitHub action to build a Docker image of ecoCode was running for PRs coming from a fork (as it is the case here). But it couldn't publish the image because of a permission issue. I disabled the action if the PR comes from a fork, so it should work now if you update the PR

@jycr
Copy link
Contributor Author

jycr commented Mar 28, 2023

Hi @jycr, review done, please make modifications and then I will approve your PR.

I've pushed all needed changes.
@dedece35: is everything compliant so that you can validate the PR?

@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.7% 2.7% Duplication

@dedece35 dedece35 merged commit e514e1a into green-code-initiative:main Mar 29, 2023
@utarwyn utarwyn mentioned this pull request Mar 30, 2023
Merged
@jycr jycr mentioned this pull request Apr 3, 2023
Merged
@jycr jycr deleted the feature/63--add-ecoCode-plugin-to-sonarQube-marketplace branch July 21, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utarwyn utarwyn utarwyn requested changes

@dedece35 dedece35 dedece35 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jycr @dedece35 @utarwyn