Upgrade some versions + sonar version from 9.3 to 9.8 #15

oussamaLaribi · 2022-12-14T13:57:03Z

No description provided.

dedece35 · 2022-12-14T14:35:21Z

Hi @oussamaLaribi,
i've just made a review with some questions. please see them.
another question / note :

do you run tests locally ? unit tests and manual tests with integration of plugin in a old SonarQube like a 9.3 version ? (to verify compatibility)
I've just corrected a mistake in build github worklfow on main branch (during repository migration, I disabled build&analyse phase because of sonarQube secrets not ready) : I've just enabled again a build&test phase in build github workflow, I relaunch the worklow for your branch to check my correction with your branch, but your banch is not up-to-date ... could you upgrade your branch and commit again something to run the workflow automatically please ?
next step will be to report this sonarQube upgrade to ecocode-mobile, please

oussamaLaribi · 2022-12-14T14:52:27Z

Hi @oussamaLaribi, i've just made a review with some questions. please see them. another question / note :

do you run tests locally ? unit tests and manual tests with integration of plugin in a old SonarQube like a 9.3 version ? (to verify compatibility)

I've just corrected a mistake in build github worklfow on main branch (during repository migration, I disabled build&analyse phase because of sonarQube secrets not ready) : I've just enabled again a build&test phase in build github workflow, I relaunch the worklow for your branch to check my correction with your branch, but your banch is not up-to-date ... could you upgrade your branch and commit again something to run the workflow automatically please ?

next step will be to report this sonarQube upgrade to ecocode-mobile, please

Hi @dedece35, thanks for the review.
Yes, I did those local tests.
I upgraded my branch also. It's up to date now.
Next, I will report this sonarQube upgrade to ecocode-mobile.

dedece35 · 2022-12-14T15:07:55Z

@oussamaLaribi ok for new workflow with build&test phase.
but you don't take into account my 3 pending review comments 😜 : please see above.

oussamaLaribi · 2022-12-14T15:18:57Z

@oussamaLaribi ok for new workflow with build&test phase. but you don't take into account my 3 pending review comments 😜 : please see above.

@dedece35 I can't find these pending review comments.
Also for the integration of the plugin in an old SonarQube, it requires at least SonarQube 9.4

pom.xml

python-plugin/pom.xml

python-plugin/src/main/java/fr/cnumr/python/RulesList.java

dedece35 · 2022-12-14T15:41:50Z

@oussamaLaribi, sorry, my bad, I forget to submit my review :p : done.
now, if SonarQube 9.4 is required, I think you have to mention it in installation documentation.

oussamaLaribi · 2022-12-14T15:54:23Z

@oussamaLaribi, sorry, my bad, I forget to submit my review :p : done. now, if SonarQube 9.4 is required, I think you have to mention it in installation documentation.

@dedece35 Okay, I'll mention it. Thanks

dedece35 · 2022-12-15T13:50:03Z

Hi @oussamaLaribi ,
I made few minutes ago a refactoring / optimization on pom.xml files : there were some mistakes on scopes on dependencies.
Please, update your branch with my modifications. I think you will have some conflicts, be carefull.

Then you can delete "compile" because it is the default scope on your dependency sonar-plugin-api-impl

oussamaLaribi · 2022-12-15T13:54:49Z

Hi @oussamaLaribi , I made few minutes ago a refactoring / optimization on pom.xml files : there were some mistakes on scopes on dependencies. Please, update your branch with my modifications. I think you will have some conflicts, be carefull.

Then you can delete "compile" because it is the default scope on your dependency sonar-plugin-api-impl

Hi @dedece35, Okay I'll do it. Thanks.

dedece35 · 2022-12-15T18:46:41Z

@oussamaLaribi, I can help if you need. tell me if you want some help.

oussamaLaribi · 2022-12-16T08:32:03Z

@oussamaLaribi, I can help if you need. tell me if you want some help.

Hi @dedece35, There's something wrong with the python plugin. After the update, it builds with the previous version and compiles with the new version. I am looking for a way to solve it.

dedece35 · 2022-12-16T19:51:23Z

hi @oussamaLaribi , do you want to say java plugin instead ? because there is compilation failure on java plugin class.
tell me if you want some help.

oussamaLaribi · 2022-12-16T20:22:56Z

hi @oussamaLaribi , do you want to say java plugin instead ? because there is compilation failure on java plugin class. tell me if you want some help.

Hi @dedece35, you can check now the compilation failure on the python plugin class.

dedece35 · 2022-12-16T23:39:45Z

@oussamaLaribi
I made the correction of the problem : several problems on pom.xml files
I made a temporary PR #20 for you to check my modifications : please take into account all modifications on all pom.xml files : check commit 565dd48
Problem was mainly in versions of python / php plugins.
I checked locally :

compilation
package building
deploy and execution of JAR plugins on a dockerized SonarQube

oussamaLaribi · 2022-12-19T08:38:21Z

@oussamaLaribi I made the correction of the problem : several problems on pom.xml files I made a temporary PR #20 for you to check my modifications : please take into account all modifications on all pom.xml files : check commit 565dd48 Problem was mainly in versions of python / php plugins. I checked locally :

compilation

package building

deploy and execution of JAR plugins on a dockerized SonarQube

Hi @dedece35, Okay I'll check it. Thanks.

This reverts commit 3765f2b.

I d'ont know if you finushed to apply my #20 PR modifications

dedece35 · 2022-12-21T23:05:28Z

Hi @oussamaLaribi
is it all ok for you thus I can do again a complete review ?

oussamaLaribi · 2022-12-22T08:18:27Z

Hi @oussamaLaribi is it all ok for you thus I can do again a complete review ?

Hi @dedece35 Yes, just the commented code "requirePlugins" . I can't find another way to force it, in the official doc there is nothing.

INSTALL.md

docker-compose.yml

pom.xml

python-plugin/src/main/java/fr/cnumr/python/RulesList.java

python-plugin/pom.xml

dedece35

@oussamaLaribi , i've just made a new review. I put here some new comments.
cheers, it's almost done :p

oussamaLaribi · 2022-12-23T08:51:48Z

new review

Hi @dedece35, it's done. Thanks.

dedece35

I check again and test again localy with all your last modifications.
It's now ok : you can merge your branch.

Another thing with minor priority, there is WARNINGs during build process in the console (tool_build.sh file execution).
After SonarQube has been started, plugins are ok regarding logs, but I think we have to find a solution to correct those Warnings during build phase. This problem is due to maven-shade-plugin added. Check capture above :

dedece35 · 2022-12-25T22:36:16Z

Hi @oussamaLaribi, I've just merged your PR and checked in main branch again (all is ok).
Please report all last modifications to ecocode-mobile repository and make me reviewer

oussamaLaribi · 2022-12-26T08:39:18Z

Hi @oussamaLaribi, I've just merged your PR and checked in main branch again (all is ok). Please report all last modifications to ecocode-mobile repository and make me reviewer
Hi @dedece35, Okay I'll do it. Thanks.

oussamaLaribi added 3 commits December 14, 2022 14:39

Upgrade some versions and sonar from 9.4 to 9.7

06960c0

Fix format

a50345c

Fix format

e632eec

oussamaLaribi changed the title ~~Upgrade some versions + sonar version from 9.4 to 9.7~~ Upgrade some versions + sonar version from 9.3 to 9.7 Dec 14, 2022

Merge branch 'main' into main

28581dd

dedece35 reviewed Dec 14, 2022

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

python-plugin/pom.xml Outdated Show resolved Hide resolved

python-plugin/src/main/java/fr/cnumr/python/RulesList.java Show resolved Hide resolved

dedece35 added 🚀 enhancement New feature or request dependencies Pull requests that update a dependency file php java python labels Dec 14, 2022

oussamaLaribi and others added 3 commits December 14, 2022 17:45

Add review changes

1b9cd4b

Fix names

0b8051a

Merge branch 'main' into main

e79bbdc

dedece35 previously approved these changes Dec 15, 2022

View reviewed changes

Merge branch 'main' into main

3a30a3b

Fix dependency

1d008fd

dedece35 assigned oussamaLaribi Dec 16, 2022

oussamaLaribi added 4 commits December 19, 2022 12:03

Fix dependency versions + add maven maven-shade-plugin to shade

5c7aa50

Format code

453f6a8

Add images to the description files.

3765f2b

Revert "Add images to the description files."

b2012a7

This reverts commit 3765f2b.

dedece35 self-requested a review December 21, 2022 23:03

dedece35 mentioned this pull request Dec 22, 2022

Error when running sonar scan with ecocode #22

Closed

dedece35 reviewed Dec 22, 2022

View reviewed changes

dedece35 requested changes Dec 22, 2022

View reviewed changes

New review fix

9338329

oussamaLaribi changed the title ~~Upgrade some versions + sonar version from 9.3 to 9.7~~ Upgrade some versions + sonar version from 9.3 to 9.8 Dec 23, 2022

dedece35 approved these changes Dec 23, 2022

View reviewed changes

Merge branch 'main' into main

76fd1c8

dedece35 mentioned this pull request Dec 23, 2022

Feature : generation docker-compose by maven (manual from @dedece35) #9

Open

dedece35 merged commit 8bdcc4a into green-code-initiative:main Dec 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade some versions + sonar version from 9.3 to 9.8 #15

Upgrade some versions + sonar version from 9.3 to 9.8 #15

oussamaLaribi commented Dec 14, 2022

dedece35 commented Dec 14, 2022 •

edited

Loading

oussamaLaribi commented Dec 14, 2022

dedece35 commented Dec 14, 2022

oussamaLaribi commented Dec 14, 2022 •

edited

Loading

dedece35 commented Dec 14, 2022

oussamaLaribi commented Dec 14, 2022

dedece35 commented Dec 15, 2022

oussamaLaribi commented Dec 15, 2022

dedece35 commented Dec 15, 2022

oussamaLaribi commented Dec 16, 2022

dedece35 commented Dec 16, 2022

oussamaLaribi commented Dec 16, 2022

dedece35 commented Dec 16, 2022 •

edited

Loading

oussamaLaribi commented Dec 19, 2022

dedece35 commented Dec 21, 2022

oussamaLaribi commented Dec 22, 2022 •

edited

Loading

dedece35 left a comment •

edited

Loading

oussamaLaribi commented Dec 23, 2022

dedece35 left a comment •

edited

Loading

dedece35 commented Dec 25, 2022 •

edited

Loading

oussamaLaribi commented Dec 26, 2022

Upgrade some versions + sonar version from 9.3 to 9.8 #15

Upgrade some versions + sonar version from 9.3 to 9.8 #15

Conversation

oussamaLaribi commented Dec 14, 2022

dedece35 commented Dec 14, 2022 • edited Loading

oussamaLaribi commented Dec 14, 2022

dedece35 commented Dec 14, 2022

oussamaLaribi commented Dec 14, 2022 • edited Loading

dedece35 commented Dec 14, 2022

oussamaLaribi commented Dec 14, 2022

dedece35 commented Dec 15, 2022

oussamaLaribi commented Dec 15, 2022

dedece35 commented Dec 15, 2022

oussamaLaribi commented Dec 16, 2022

dedece35 commented Dec 16, 2022

oussamaLaribi commented Dec 16, 2022

dedece35 commented Dec 16, 2022 • edited Loading

oussamaLaribi commented Dec 19, 2022

dedece35 commented Dec 21, 2022

oussamaLaribi commented Dec 22, 2022 • edited Loading

dedece35 left a comment • edited Loading

Choose a reason for hiding this comment

oussamaLaribi commented Dec 23, 2022

dedece35 left a comment • edited Loading

Choose a reason for hiding this comment

dedece35 commented Dec 25, 2022 • edited Loading

oussamaLaribi commented Dec 26, 2022

dedece35 commented Dec 14, 2022 •

edited

Loading

oussamaLaribi commented Dec 14, 2022 •

edited

Loading

dedece35 commented Dec 16, 2022 •

edited

Loading

oussamaLaribi commented Dec 22, 2022 •

edited

Loading

dedece35 left a comment •

edited

Loading

dedece35 left a comment •

edited

Loading

dedece35 commented Dec 25, 2022 •

edited

Loading