[ISSUE 92] Centralized rules repository

[jycr]

Implements #92

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
35 Code Smells

61.5% Coverage
17.4% Duplication

[jycr]

I fixed/answered all of @dedece35 's feedbacks

[dedece35]

@jycr, as mentioned during friday meeting, please wait #188 (just done) and #201 before merging this one

[dedece35]

review OK now.
but after merging main branch on your branch (after #187 and #201 ), I would like to test myself and check if I see some problems on my local machine, please.
tell me when merges are ok on your branch.

[dedece35]

@jycr
2 waiting PRs has just been merged (#187 and #201)
you can now get main code on your branch
I can help you if you have problems on conflicts.

[dedece35]

Hi @jycr
first quick review : first of all, please correct 21 code smells

[utarwyn]

LGTM in my opinion 💯
Maybe wait for another validation before merging to be sure?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[dedece35]

Hi @jycr,
last check in my local machine before merging :p

my tests are ok and now ok for merge.
I've just done it by myself but several things to correct in main branch please :

• when I launch tool_build.sh there are several WARNINGs that we did'nt have before in main branch
  • each plugin build generates a WARNING regarding shade plugin : see maven-shade-plugin has detected that some files are ... warning message
  • asciidoctor plugin generates several warning with message starting with [WARNING] Duplicated destination found: overwriting file: ...
• did you write a process to publish a new version of ecocode-rules-specifications module into maven central ? as I understand, in the near future, there will be only the content of ecocode-rules-specifications module in ecocode repository. But for now, there is also other languages, thus we have to publish this module differently than the final way, isn't it ?

[jycr]

Hi @jycr, last check in my local machine before merging :p

my tests are ok and now ok for merge. I've just done it by myself but several things to correct in main branch please :

• when I launch tool_build.sh there are several WARNINGs that we did'nt have before in main branch

  • each plugin build generates a WARNING regarding shade plugin : see maven-shade-plugin has detected that some files are ... warning message
  • asciidoctor plugin generates several warning with message starting with [WARNING] Duplicated destination found: overwriting file: ...

• did you write a process to publish a new version of ecocode-rules-specifications module into maven central ? as I understand, in the near future, there will be only the content of ecocode-rules-specifications module in ecocode repository. But for now, there is also other languages, thus we have to publish this module differently than the final way, isn't it ?

I will check those points on my local to find fixes and propose a new PR.

Regarding publishing in Maven central, I will check that point in few days