Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java - Rules "Optimize Database Queries" #221

Closed
wants to merge 8 commits into from
Closed

Java - Rules "Optimize Database Queries" #221

wants to merge 8 commits into from

Conversation

tazemar
Copy link

@tazemar tazemar commented Aug 11, 2023

Rule ID : Should I open an issue?

Rule description : https://github.com/cnumr/best-practices/blob/main/chapters/BP_075_en.md

@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@tazemar tazemar changed the title Java - Rules "Optimize Qatabase Queries" Java - Rules "Optimize Database Queries" Aug 23, 2023
@dedece35 dedece35 self-requested a review September 22, 2023 09:40
dedece35
dedece35 requested changes Sep 22, 2023
View reviewed changes
Copy link
Member

@dedece35 dedece35 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tazemar,
thank you for you PR. I'm OK with it but several points aren't OK : please check DoD list here https://github.com/green-code-initiative/ecoCode-common/blob/main/doc/starter-pack.md#definition-of-done-of-a-pr

Also, add a new line for this new rule in RULES.md file, please.

Then, please, mention these points here to check them.

And, yes, I agree with you, if you can create an new issue associated with this PR ... please create an issue with "new rule suggestion" template when you click on "new issue".

tazemar and others added 2 commits October 30, 2023 17:01
@tazemar @dedece35
@utarwyn @jycr
Update main (#4)
a3cbce5 
Co-authored-by: David DE CARVALHO <dedece35@gmail.com>
Co-authored-by: Maxime Malgorn <9255967+utarwyn@users.noreply.github.com>
Co-authored-by: utarwyn <maxime.malgorn@laposte.net>
Co-authored-by: jycr <jycr@users.noreply.github.com>
@tazemar
Merge branch 'main' into rule/OptimizeDatabaseQueries
d50a067
@tazemar tazemar mentioned this pull request Oct 30, 2023
Open
dedece35
dedece35 requested changes Nov 10, 2023
View reviewed changes
ecocode-rules-specifications/src/main/rules/EC475/EC475.json
@@ -0,0 +1,11 @@
{
"title": "Optimize Database Queries",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, for me title is quite wrong, like class names above, because you deal with database queries only for relational databases (and not NOSql databases for example). Thus, could you add "SQL" word in title, class names, descriptions, documentation, etc ... please

also, there are some lacks if you check DoD list https://github.com/green-code-initiative/ecoCode-common/blob/main/doc/starter-pack.md#definition-of-done-of-a-pr - example :

  • update RULES.md
  • update CHANGELOG.md
  • add test in real test repository
  • ...

@dedece35 dedece35 linked an issue Nov 10, 2023 that may be closed by this pull request
New Rule suggestion : Optimize Database Queries #239
Open
@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has no activity for 60 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 14, 2024
@dedece35 dedece35 mentioned this pull request Mar 18, 2024
Open
@dedece35 dedece35 added the duplicate This issue or pull request already exists label Mar 18, 2024
@github-actions github-actions bot removed the stale label Mar 19, 2024
@dedece35 dedece35 removed a link to an issue Apr 26, 2024
New Rule suggestion : Optimize Database Queries #239
Open
@dedece35
Copy link
Member

Hi @tazemar,
as no answer to my questions and to follow our process on PR, we close this PR and get your code in another PR on ecocode-java repository : green-code-initiative/ecoCode-java#20

@dedece35 dedece35 closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedece35 dedece35 dedece35 requested changes

Assignees

@tazemar tazemar

Labels
🗃️ rule rule improvment or rule development or bug duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tazemar @dedece35