Add images to the description files.

[oussamaLaribi]

Add an image to the description of rule s72 [PHP].

[dedece35]

Hi @oussamaLaribi
I don't understand why you want to add an JPG image to docker instances

What is the purpose ?

[oussamaLaribi]

Hi @oussamaLaribi I don't understand why you want to add an JPG image to docker instances

What is the purpose ?

Hi @dedece35, the purpose is to add benchmark images to the rule description. I tried with just the image source, but it is not loaded into the Sonor Qube description rule when I start docker instances. So I decided to add it to the instance and it worked.

[dedece35]

Hi @oussamaLaribi,
I've juste tested locally your PR but it is'nt ok for me, sorry. Several problems :

• tool build docker image and start it, I must
  • modify docker-compose.yml to change 0.1.0-SNAPHOT versions to 0.1.1-SNAPSHOT version
  • next, change source: common to source: ./common
• after SonarQube started, the image is broken (check joined capture) where image URL is http://localhost:9000/opt/sonarqube/common/images/php/s72_percent_comparison.jpg : for me it can't work because this url path is not exposed on SonarQube
  • i found some other images on SonarQube server where images are stored on directory /opt/sonarqube/images

for now, I d'ont have a solution, sorry, but please make checks again

[oussamaLaribi]

Hi @oussamaLaribi, I've juste tested locally your PR but it is'nt ok for me, sorry. Several problems :

• tool build docker image and start it, I must

  • modify docker-compose.yml to change 0.1.0-SNAPHOT versions to 0.1.1-SNAPSHOT version
  • next, change source: common to source: ./common

• after SonarQube started, the image is broken (check joined capture) where image URL is http://localhost:9000/opt/sonarqube/common/images/php/s72_percent_comparison.jpg : for me it can't work because this url path is not exposed on SonarQube

  • i found some other images on SonarQube server where images are stored on directory /opt/sonarqube/images

for now, I d'ont have a solution, sorry, but please make checks again

Hi @dedece35, Okay I'll check it. Thanks.

[oussamaLaribi]

Hi, @dedece35. I used a different option. I used Flickr for storing pictures it's free. "Flickr is a media platform used for uploading, organizing, and sharing digital media such as photos and videos."

[dedece35]

please add a comment in changelog file, in "unreleased" part

[oussamaLaribi]

please add a comment in changelog file, in "unreleased" part

Hi @dedece35, Okay I'll do it. Thanks.