Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/migrate mobile rule #237

Merged
merged 11 commits into from
Oct 28, 2023
Merged

Feature/migrate mobile rule #237

merged 11 commits into from
Oct 28, 2023

Conversation

jycr
Copy link
Contributor

@jycr jycr commented Oct 22, 2023

No description provided.

@jycr
chore: Adds rule specifications from: https://github.com/green-code-i…
cba9523 
…nitiative/ecoCode-android/tree/e5960e0c03566d33d9bec051103b7ff36879301b/android-plugin/src/main/resources/org/sonar/l10n/java/rules/squid
@jycr
chore: Adds rule specifications from: https://github.com/green-code-i…
18ff499 
…nitiative/ecoCode-android/tree/e5960e0c03566d33d9bec051103b7ff36879301b/android-plugin/src/main/resources/io/ecocode/xml/rules
@jycr
chore: Adds rule specifications from: https://github.com/green-code-i…
e8d214f 
…nitiative/ecoCode-ios/tree/6298bddbd97f3ec8b6dbc353a89c452a6d3ef0e1/swift-lang/src/main/resources
@jycr
refactor(rule/android - java): Modify rule keys
ce9105c
@jycr
feat(rule/android - java): Convert HTML to ASCIIDOC
29e326d
@jycr
refactor(rule/android - java): Move ecoScore to JSON metadata
135f0c9
@jycr
refactor(rule/android - xml): Modify rule keys
8b4a685
@jycr
refactor(rule/ios - swift): Modify rule keys
a95712e
@jycr
feat(rule/ios - swift): Convert HTML to ASCIIDOC
5a28f8d
@jycr
feat(rule/android - xml): Convert HTML to ASCIIDOC
a751983
@dedece35 dedece35 added 🚀 enhancement New feature or request 🏗️ refactoring refactoring for best practices labels Oct 22, 2023
dedece35
dedece35 previously approved these changes Oct 22, 2023
View reviewed changes
utarwyn
utarwyn reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this configuration, a lot of mobile rules will be in the "Java part" of the rules specification artifact. So they will be included in both Java and Android plugins. I imagine you have this in mind? as it stands, it's not a problem, but we're going to include some useless rules in the JAR files

Just a thought, open to discussion

@jycr
Copy link
Contributor Author

jycr commented Oct 27, 2023

In this configuration, a lot of mobile rules will be in the "Java part" of the rules specification artifact. So they will be included in both Java and Android plugins. I imagine you have this in mind? as it stands, it's not a problem, but we're going to include some useless rules in the JAR files

Just a thought, open to discussion

You're absolutely right.
This is a known consequence which has already been mentioned.
I'm waiting for our ideas to be clearer regarding our "target/platform" (compared to the different plugins proposed by the green-code-initiative community) in order to propose something even more optimal.

@jycr jycr requested a review from utarwyn October 27, 2023 17:00
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jycr jycr requested a review from dedece35 October 27, 2023 17:14
utarwyn
utarwyn reviewed Oct 27, 2023
View reviewed changes
ecocode-rules-specifications/src/main/rules/EC544/xml/EC544.asciidoc
@@ -0,0 +1,13 @@
Score ecoCode: 2sur5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this wording is in French?

utarwyn
utarwyn approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise 💯
We can start with this architecture first and improve it if we found a better idea in the future

@utarwyn
Copy link
Member

utarwyn commented Oct 27, 2023

@jycr Thank you for the version 0.0.5!
I'm waiting for a new one with rules from #226 (integrated few minutes ago) and rules from this PR if you want

@jycr jycr merged commit 20035d7 into main Oct 28, 2023
3 checks passed
@jycr jycr deleted the feature/migrate-mobile-rule branch October 28, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utarwyn utarwyn utarwyn approved these changes

@dedece35 dedece35 dedece35 approved these changes

@jhertout jhertout Awaiting requested review from jhertout

Assignees

@jycr jycr

Labels
🏗️ refactoring refactoring for best practices 🚀 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jycr @utarwyn @dedece35