Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EC63] Deprecation of rule EC63 for java #258

Merged
merged 4 commits into from
Dec 11, 2023
Merged

[EC63] Deprecation of rule EC63 for java #258

merged 4 commits into from
Dec 11, 2023

Conversation

dedece35
Copy link
Member

@dedece35 dedece35 added 🗃️ rule rule improvment or rule development or bug java labels Dec 10, 2023
@dedece35 dedece35 self-assigned this Dec 10, 2023
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Can you also update the documentation file in rules specitification artifact, like what I have done in #243? I'm not sure that the rule really appears as deprecated in the interface without this modification.

EDIT: And I think we also need to add a sentence at the top of the asciidoc file to explain why this rule is deprecated

The code is here:

@dedece35
Copy link
Member Author

Hello! Can you also update the documentation file in rules specitification artifact, like what I have done in #243? I'm not sure that the rule really appears as deprecated in the interface without this modification.

EDIT: And I think we also need to add a sentence at the top of the asciidoc file to explain why this rule is deprecated

The code is here:

corrections done

utarwyn
utarwyn previously approved these changes Dec 10, 2023
Copy link

sonarcloud bot commented Dec 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dedece35 dedece35 merged commit e1ba914 into main Dec 11, 2023
3 checks passed
@dedece35 dedece35 deleted the EC63_deprecation branch December 11, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗃️ rule rule improvment or rule development or bug java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants