Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big cleanup / sorting of mobile related rules #302

Merged
merged 1 commit into from
May 20, 2024
Merged

Big cleanup / sorting of mobile related rules #302

merged 1 commit into from
May 20, 2024

Conversation

zippy1978
Copy link
Contributor

Done In this PR:

  • merged XML/Java Android duplicated rules under the same ID
  • sorted Swift rules not matching Android equivalent rule

@zippy1978 zippy1978 requested a review from dedece35 May 17, 2024 13:58
@zippy1978 zippy1978 self-assigned this May 17, 2024
zippy1978 pushed a commit to green-code-initiative/ecoCode-ios that referenced this pull request May 17, 2024
refact(Rules): rules re-numbering to match unified repository IDs (gr…
994bf41 
…een-code-initiative/ecoCode#302)
@olegoaer olegoaer requested a review from jhertout May 18, 2024 08:05
jhertout
jhertout approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@jhertout jhertout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me. I created in the android plugin project to update the IDs but you can merge when you want, we do not use this project for the moment.

@zippy1978 zippy1978 merged commit bddb4f7 into main May 20, 2024
1 check passed
@zippy1978 zippy1978 deleted the fix/mobile-rules-sorting branch May 20, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhertout jhertout jhertout approved these changes

@dedece35 dedece35 Awaiting requested review from dedece35

Assignees

@zippy1978 zippy1978

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zippy1978 @jhertout