Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Swift version of EC514 #307

Merged
merged 6 commits into from
May 30, 2024
Merged

Added Swift version of EC514 #307

merged 6 commits into from
May 30, 2024

Conversation

zippy1978
Copy link
Contributor

A port of EC514 rule.
This rule already exists for Android / Java.

Addresses issue #306

@zippy1978 zippy1978 added the 🗃️ rule rule improvment or rule development or bug label May 29, 2024
@zippy1978 zippy1978 self-assigned this May 29, 2024
@zippy1978 zippy1978 requested a review from a team May 29, 2024 13:21
utarwyn
utarwyn previously approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! 👍

@zippy1978 zippy1978 requested a review from a team May 30, 2024 12:00
@dedece35 dedece35 linked an issue May 30, 2024 that may be closed by this pull request
[EC514] Swift port #306
Closed
@dedece35 dedece35 merged commit 1077684 into main May 30, 2024
1 check passed
@dedece35 dedece35 deleted the rule/EC514-swift branch May 30, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedece35 dedece35 dedece35 approved these changes

@utarwyn utarwyn utarwyn left review comments

Assignees

@zippy1978 zippy1978

Labels
🗃️ rule rule improvment or rule development or bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EC514] Swift port
3 participants
@zippy1978 @utarwyn @dedece35