Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Adding name, group, description to KeyMap #154

Closed
huv1k opened this issue Mar 12, 2019 · 4 comments
Closed

[FEATURE] Adding name, group, description to KeyMap #154

huv1k opened this issue Mar 12, 2019 · 4 comments

Comments

@huv1k
Copy link
Contributor

huv1k commented Mar 12, 2019

I am missing description for KeyMap, this could work great with getApplicationKeyMap building dynamic keymap. Lot of websites show keymap with combination shift+?. For example github example:

Possible solution

const keyMap = {
  SUBMIT_COMMET: {
    name: 'Submit comment',
    group: 'Issue',
    description: 'Submit comment',
    sequence: 'command+enter'
  }
}
@greena13
Copy link
Owner

Hi @HuVik, this is an excellent idea and matches up with some future plans I had for the library.

I will try and add it into the next release.

@huv1k
Copy link
Contributor Author

huv1k commented Mar 29, 2019

This is only one thing I am missing right now:)

@greena13 greena13 changed the title Adding name, group, description to KeyMap [FEATURE] Adding name, group, description to KeyMap Jun 3, 2019
@greena13
Copy link
Owner

greena13 commented Jun 8, 2019

This has been added and will be available in the next release.

@greena13 greena13 closed this as completed Jun 8, 2019
@greena13
Copy link
Owner

This feature is now available in v2.0.0-pre8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants