Activate improvements #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The settigs contain the mode and the list of activated plugin modules. The class allows to write the mode and plugins to a toml file like the pyproject.toml.
The argument modestring is actuallly optional.
The method is the same as has_autohooks_config.
Move checking for an existing and determining the path to the projects pyproject.toml file into the load_config_from_pyproject_toml function and generalize the AutohooksConfig method to be independent of the pyproject.toml.
The BaseToolConfig was only used in the AutohooksConfig class. Therefore there is no need for a class hierarchy. While merging remove the has_config method which was only used in tests.
Currently this method just shadows the constructor but this will change in additional commits.
Using the AutohooksSettings makes the class simpler.
Make the installation and usage of autohooks much easier by not having to edit the pyproject toml config file manually. If there is no settings for autohooks or changes are forced autohooks activate will write the settings to the pyproject.toml file.
Codecov Report
@@ Coverage Diff @@
## main #345 +/- ##
==========================================
+ Coverage 87.69% 88.16% +0.47%
==========================================
Files 13 13
Lines 577 600 +23
==========================================
+ Hits 506 529 +23
Misses 71 71
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
3 tasks
Dexus
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Improve installation, setup and usage of
autohooks activateby writing the settings to thepyproject.tomlfile.With this change the user doesn't need to change the
pyproject.tomlfile manually during the setup.Why:
Make the setup easier.
How:
Checklist: