Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Change pre-commit shebang line when using poetry #381

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Fix: Change pre-commit shebang line when using poetry #381

merged 1 commit into from
Oct 10, 2022

Conversation

kidylee
Copy link
Contributor

@kidylee kidylee commented Oct 10, 2022

What:
Fix: Change pre-commit shebang line when using poetry

Why:
pre-commit not able to run on windows due to poetry doesn't create python3 alias in virtualenv.

How:

Change shebang from poetry run python3 to poetry run python when using poetry mode.

Checklist:

  • Tests
  • PR merge commit message adjusted
  • Documentation

@kidylee kidylee requested a review from a team as a code owner October 10, 2022 09:31
@y0urself y0urself enabled auto-merge (squash) October 10, 2022 09:41
@bjoernricks bjoernricks mentioned this pull request Oct 10, 2022
Closed
3 tasks
@y0urself y0urself merged commit e851c7d into greenbone:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kidylee @bjoernricks @y0urself