Dashboard improvements #1022
Merged
Dashboard improvements #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bjoernricks
commented
Oct 15, 2018
bjoernricks
commented
- store display (chart) specific data in the in the user settings
- fix main dashboard
- fix rendering the linechart
memoize-one caches a return value of a function depending on the passed parameters.
Put the display specific state in the dashboard settings at the redux store.
Forward the settings passed to StartDashboard to the Dashboard and DashboardControls.
Rework main Dashboard to abstract settings and dashboard settings.
The line chart must re-render if with, data and height has changed. After the state has been calculated the re-render must be allowed in shouldComponentUpdate by checking if the data in the state has changed since last render. The state calculation in LineChart is far from beeing optimal. Maybe all charts could be simplified by extracting the width re-calculation when a legend is displayed into another separated reusable component.
Codecov Report
@@ Coverage Diff @@
## master #1022 +/- ##
=========================================
- Coverage 9.51% 9.5% -0.02%
=========================================
Files 820 820
Lines 26615 26650 +35
Branches 5616 5621 +5
=========================================
Hits 2533 2533
- Misses 22466 22499 +33
- Partials 1616 1618 +2
Continue to review full report at Codecov.
|
The settings are loaded via the main dashboard so isLoading is always false for these dashboards.
The store layout is a bit confusing the for main dashboard because it's so complex. Fix getting the isLoading indicator.
swaterkamp
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.