SMB alert update 7.0 #1110
Merged
SMB alert update 7.0 #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used to select whether the alert should use smb_file_path as the whole path or just as the directory.
The hyphen was not properly escaped in the tag name validation and backslashes are now allowed in the value for Windows paths.
These new options will allow selecting whether the file path will be treated as a full path or just the directory.
bjoernricks
previously approved these changes
Dec 27, 2018
|
Please add a CHANGES entry |
|
@timopollmeier could you please add an entry to the changelog file? Otherwise this PR seems to be fine. |
The support for the "smb-alert:file_path" task tag will stay, while the options using smb_file_path_type will be removed again later.
bjoernricks
approved these changes
Jan 21, 2019
|
Sorry, I was holding back on this because of plans to change the way the path will work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the SMB file path and tagging options from #1107 and adds the dialog options like #1109.
Requires greenbone/gvmd#296.