Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user logout and update after password change #1159

Merged
merged 3 commits into from
Feb 4, 2019

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Feb 1, 2019

This fixes a crash when the password is changed for a user that is not
logged and corrects the session_remove_other_sessions call to keep
the session sending the command active.
When changing the current user, the username is now also updated if
the password stays the same.

Checklist:

This fixes a crash when the password is changed for a user that is not
logged and corrects the session_remove_other_sessions call to keep
the session sending the command active.
When changing the current user, the username is now also updated if
the password stays the same.
@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #1159 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1159      +/-   ##
==========================================
- Coverage   15.38%   15.28%   -0.11%     
==========================================
  Files         867      843      -24     
  Lines       27100    27025      -75     
  Branches     5776     5770       -6     
==========================================
- Hits         4170     4131      -39     
+ Misses      21540    21494      -46     
- Partials     1390     1400      +10
Impacted Files Coverage Δ
gsa/src/web/components/icon/trashdeleteicon.js 0% <0%> (-100%) ⬇️
gsa/src/web/utils/selectiontype.js 0% <0%> (-100%) ⬇️
gsa/src/web/components/icon/restoreicon.js 0% <0%> (-100%) ⬇️
gsa/src/web/components/icon/deleteicon.js 0% <0%> (-75%) ⬇️
gsa/src/web/components/icon/exporticon.js 0% <0%> (-75%) ⬇️
gsa/src/web/components/icon/trashicon.js 0% <0%> (-75%) ⬇️
gsa/src/web/components/pagination/pagination.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/filters/listpage.js 0% <0%> (ø) ⬆️
...b/components/dashboard/display/datadisplayicons.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/results/detailspage.js 0% <0%> (ø) ⬆️
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c6c3f3...538ec5d. Read the comment docs.

@timopollmeier timopollmeier requested a review from a team February 1, 2019 16:38
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@bjoernricks bjoernricks merged commit 5491424 into greenbone:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants