Change order of options in TargetDialog #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change lets the user see all possible credential dropdowns and instead "hides" the Reverse lookup Only and ReverseLookup Unify options. The only indication that they are there is the scrollbar on the right, but I don't regard this as problem as it seems to be consens that those settings are "advanced mode" anyway.
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1233 +/- ##
========================================
Coverage 17.21% 17.21%
========================================
Files 950 950
Lines 27607 27607
Branches 5941 5950 +9
========================================
Hits 4753 4753
Misses 21400 21400
Partials 1454 1454
Continue to review full report at Codecov.
|
bjoernricks
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lets the user see all possible credential dropdowns and
instead "hides" the Reverse Lookup Only and Reverse Lookup Unify options.
The only indication that they are there is the scrollbar on the right,
but I don't regard this as problem as it seems to be consensus that those
settings are "advanced mode" anyway.
Checklist: