Guest user #1246
Merged
Guest user #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to provide login information for a guest user.
Show a guest login button at the login page if guestUsername and guestPassword are set in the config.js file. Also move the Wrapper to the LoginForm component.
Allow to disable displaying the login form by setting
config = {
disableLoginForm: true,
}
in the config.js file.
Allow to enable/disbale the protocol insecure warning at the LoginForm by passing a showProtocolInsecure prop. By default the warning isn't shown.
Normally it's a mistake if they are missing. Therefore issue a prop warning in that case.
autocomplete hints are used by the browser to autofill the fields.
swaterkamp
reviewed
Apr 2, 2019
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1246 +/- ##
===========================================
+ Coverage 17.35% 17.52% +0.16%
===========================================
Files 950 950
Lines 27628 27630 +2
Branches 5959 5969 +10
===========================================
+ Hits 4795 4841 +46
+ Misses 21387 21344 -43
+ Partials 1446 1445 -1
Continue to review full report at Codecov.
|
swaterkamp
reviewed
Apr 2, 2019
swaterkamp
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for guest user login. With this change a config.js file with the following content
can be provided to activate a
Login as Guestbutton at the login page. To actually use this usera user with the role Guest and the specified username/password combination must be created.
Important: It is not checked if the user is a restricted guest user. It would also be possible to auto login via a super admin user!
Additionally by adding a
disableLoginForm: trueto the config object in theconfig.jsfile it is possible to deactivate the normal login form at the login page to only provide theLogin as Guestbutton.Checklist: