Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omp url redirect #1247

Merged
merged 3 commits into from
Apr 2, 2019
Merged

Omp url redirect #1247

merged 3 commits into from
Apr 2, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Apr 2, 2019

Redirect from old secinfo urls like

https://secinfo.greenbone.net/omp?cmd=get_info&info_type=nvt&token=...

to the new version of that page.

Checklist:

This allows to redirect to a not found page from other pages without
having to render the not found in the page component itself.
Allow to preserve the old secinfo urls like

https://secinfo.greenbone.net/omp?cmd=get_info&info_type=nvt&token=...

and redirect to the new version of that page.
@bjoernricks bjoernricks requested a review from a team April 2, 2019 15:01
@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #1247 into gsa-8.0 will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1247      +/-   ##
===========================================
- Coverage    17.52%   17.49%   -0.03%     
===========================================
  Files          950      951       +1     
  Lines        27630    27667      +37     
  Branches      5969     5979      +10     
===========================================
  Hits          4841     4841              
- Misses       21344    21379      +35     
- Partials      1445     1447       +2
Impacted Files Coverage Δ
gsa/src/web/routes.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/omp.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84d3120...5df867b. Read the comment docs.

@swaterkamp swaterkamp merged commit f6923f0 into greenbone:gsa-8.0 Apr 2, 2019
@bjoernricks bjoernricks deleted the omp-url-redirect branch April 2, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants