Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for comment and badge #1309

Merged
merged 4 commits into from
Apr 25, 2019

Conversation

sarahd93
Copy link
Contributor

Checklist:

@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #1309 into gsa-8.0 will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1309      +/-   ##
===========================================
+ Coverage    18.09%   18.23%   +0.13%     
===========================================
  Files          953      953              
  Lines        27725    27713      -12     
  Branches      5994     6001       +7     
===========================================
+ Hits          5017     5053      +36     
+ Misses       21303    21263      -40     
+ Partials      1405     1397       -8
Impacted Files Coverage Δ
gsa/src/web/components/badge/badge.js 96.87% <ø> (+96.87%) ⬆️
gsa/src/web/entities/container.js 0% <0%> (ø) ⬆️
...b/components/powerfilter/createnamedfiltergroup.js 100% <0%> (ø) ⬆️
gsa/src/web/pages/permissions/listpage.js 0% <0%> (ø) ⬆️
gsa/src/gmp/models/filter.js 100% <0%> (ø) ⬆️
gsa/src/web/components/comment/comment.js 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4513f2...f7c81e8. Read the comment docs.

@sarahd93 sarahd93 changed the title Add test for comment Add tests for comment and badge Apr 25, 2019
@sarahd93 sarahd93 marked this pull request as ready for review April 25, 2019 09:15
@sarahd93 sarahd93 requested a review from a team April 25, 2019 09:15
@bjoernricks bjoernricks merged commit 1188ab3 into greenbone:gsa-8.0 Apr 25, 2019
@sarahd93 sarahd93 deleted the component_tests_gsa8 branch April 25, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants