Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use loaded filter from state in EntitiesContainer #1359

Merged
merged 2 commits into from
May 3, 2019
Merged

Use loaded filter from state in EntitiesContainer #1359

merged 2 commits into from
May 3, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented May 3, 2019

Always use the actual displayed and used loaded filter. Avoid using a
new filter that hasn't data yet. Using a not displayed filter may result
in unexpected behavior.

Checklist:

@bjoernricks bjoernricks marked this pull request as ready for review May 3, 2019 09:49
@bjoernricks bjoernricks requested a review from a team May 3, 2019 09:49
Always use the actual displayed and used loaded filter. Avoid using a
new filter that hasn't data yet. Using a not displayed filter may result
in unexpected behavior.
@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #1359 into gsa-8.0 will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1359      +/-   ##
===========================================
+ Coverage    34.78%   34.78%   +<.01%     
===========================================
  Files          959      959              
  Lines        21636    21635       -1     
  Branches      5969     5969              
===========================================
  Hits          7526     7526              
+ Misses       12766    12765       -1     
  Partials      1344     1344
Impacted Files Coverage Δ
gsa/src/web/entities/container.js 1.09% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 167a60e...355f7af. Read the comment docs.

@bjoernricks bjoernricks merged commit cf578a4 into greenbone:gsa-8.0 May 3, 2019
@bjoernricks bjoernricks deleted the container-loaded-filter branch May 3, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants