Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import report improvements #1370

Merged
merged 5 commits into from
May 9, 2019
Merged

Import report improvements #1370

merged 5 commits into from
May 9, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented May 7, 2019 •
edited
Loading

Checklist:

@bjoernricks
Avoid proptype warning at runtime
ee9f92c 
Don't raise proptype warning for changing from uncontrolled to
controlled by setting default values for name and comment fields.
@bjoernricks
Update imports at ReportImportDialog
8b2e47b 
* Use absolute imports
* Drop js endings
* Sort imports
@bjoernricks
Load all container tasks from redux store
8d7f2f6 
Improve importing reports by loading the possible container tasks from
the redux store.
@bjoernricks
Add changelog entry
37085fe
@bjoernricks bjoernricks marked this pull request as ready for review May 7, 2019 14:22
@bjoernricks bjoernricks requested a review from a team May 7, 2019 14:22
@bjoernricks bjoernricks merged commit c223869 into greenbone:gsa-8.0 May 9, 2019
@bjoernricks bjoernricks deleted the import-report branch May 9, 2019 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaterkamp swaterkamp swaterkamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @swaterkamp